Paths

Table of Contentst

Differential D9222

Add support for AHCI on ARMADA38X
ClosedPublic
Actions

Authored by mw_semihalf.com on Jan 17 2017, 4:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 8:58 PM

	Unknown Object (File)
	Fri, Nov 15, 9:37 AM

	Unknown Object (File)
	Oct 18 2024, 7:40 AM

	Unknown Object (File)
	Oct 14 2024, 9:18 AM

	Unknown Object (File)
	Sep 17 2024, 1:36 AM

	Unknown Object (File)
	Sep 11 2024, 8:36 PM

	Unknown Object (File)
	Sep 9 2024, 1:18 AM

	Unknown Object (File)
	Sep 8 2024, 8:49 PM

View All 67 Files

Subscribers

ka_semihalf.com

Details

Reviewers

zbb
fabient
imp
• ian

Commits

rS312749: Add support for AHCI on ARMADA38X

Summary

This file provides support for AHCI controllers on Marvell Armada38x SoC.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mw_semihalf.com updated this revision to Diff 24126.Jan 17 2017, 4:07 PM

mw_semihalf.com retitled this revision from to Add support for AHCI on ARMADA38X.

mw_semihalf.com updated this object.

mw_semihalf.com edited the test plan for this revision. (Show Details)

mw_semihalf.com added reviewers: • ian, imp, zbb, fabient.

mw_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

mw_semihalf.com added a parent revision: D9221: Enable optional soft reset in AHCI.

mw_semihalf.com added a child revision: D9223: Add AHCI device to arm/mv/files.mv.

mw_semihalf.com added a subscriber: ARM.

andrew mentioned this in D9223: Add AHCI device to arm/mv/files.mv.Jan 17 2017, 5:14 PM

zbb requested changes to this revision.Jan 17 2017, 7:03 PM

zbb edited edge metadata.

zbb added inline comments.

sys/dev/ahci/ahci_mv_fdt.c
106	According to my other comment for the change in AHCI, please change this code to quirk in generic AHCI.
131	Just double checked generic AHCI driver and it releases `r_mem` resource on failure. As we discussed, this should be present here only if AHCI does not release this resource and it appears it does. Please remove release resource after `ahci_attach()` here and chage back `device_detach` to generic AHCI detach. Sorry for confusion.
171	Please add `ofwbus` as well.

This revision now requires changes to proceed.Jan 17 2017, 7:03 PM

ka_semihalf.com added a subscriber: ka_semihalf.com.Jan 18 2017, 9:43 AM

Squash adding ahci to sys/arm/mv/files.mv to this commit.
Enable in ARMADA38X config.
Add DRIVER_MODULE for ofwbus.
Fix releasing resources.
Use quirk for soft reset delay.

mw_semihalf.com edited edge metadata.Jan 19 2017, 6:17 PM

mw_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

zbb accepted this revision.Jan 23 2017, 11:21 AM

zbb edited edge metadata.

This revision is now accepted and ready to land.Jan 23 2017, 11:21 AM

Closed by commit rS312749: Add support for AHCI on ARMADA38X (authored by wma). · Explain WhyJan 25 2017, 10:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ahci/

171 lines

Diff 24126

sys/dev/ahci/ahci_mv_fdt.c

Loading...