loader: beri_sdcard_disk_print() needs to return int.
ClosedPublic
Actions

Authored by tsoome on Nov 14 2016, 9:15 PM.

Details

Reviewers

brooks
kan
allanjude
imp
rstone
adrian

Commits

rS308774: loader: beri_sdcard_disk_print() needs to return int.

Summary

The return type for beri_sdcard_disk_print() should be int.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5948
Build 6229: arc lint + arc unit

Event Timeline

tsoome updated this revision to Diff 22198.Nov 14 2016, 9:15 PM

tsoome retitled this revision from to loader: beri_sdcard_disk_print() needs to return int..

tsoome updated this object.

tsoome edited the test plan for this revision. (Show Details)

tsoome added reviewers: allanjude, imp.

tsoome added a subscriber: cy.

allanjude added reviewers: brooks, kan, adrian.Nov 15 2016, 7:09 PM

You'll also want to change the declaration above the devsw initialization or this won't compile.

In D8515#177241, @brooks wrote:

You'll also want to change the declaration above the devsw initialization or this won't compile.

You mean the one at line 50? its already int - it was changed with the rest, just somehow the function itself got missed.

Oh, I see. This is fine then. Sorry I missed that.

This revision is now accepted and ready to land.Nov 15 2016, 7:22 PM

rstone accepted this revision.Nov 17 2016, 6:19 PM

rstone added a reviewer: rstone.

Approved for commit

Closed by commit rS308774: loader: beri_sdcard_disk_print() needs to return int. (authored by tsoome). · Explain WhyNov 17 2016, 6:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

boot/

mips/

beri/

loader/

beri_disk_sdcard.c

2 lines

Diff 22198

View Options

sys/boot/mips/beri/loader/beri_disk_sdcard.c

loader: beri_sdcard_disk_print() needs to return int.ClosedPublicActions