Use upstream suffixes for LLVM IR
ClosedPublic
Actions

Authored by dim on Oct 22 2016, 7:55 PM.

Details

Reviewers

emaste
imp
jonathan
rwatson

Commits

rS307823: Use upstream suffixes for LLVM IR

Summary

In rS307676 several make rules were added for LLVM IR files, both in
text and binary format. Unfortunately these use different suffixes from
what upstream uses:

Text IR has upstream suffix ".ll", while rS307676 uses ".llo"
Binary IR has upstream suffix ".bc", while rS307676 uses ".bco"

Let's change these to what upstream uses instead.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dim updated this revision to Diff 21622.Oct 22 2016, 7:55 PM

dim retitled this revision from to Use upstream suffixes for LLVM IR.

dim updated this object.

dim edited the test plan for this revision. (Show Details)

dim added reviewers: emaste, imp, jonathan, rwatson.

Herald added a subscriber: bdrewery. · View Herald TranscriptOct 22 2016, 7:55 PM

LGTM

This revision is now accepted and ready to land.Oct 22 2016, 10:41 PM

Closed by commit rS307823: Use upstream suffixes for LLVM IR (authored by dim). · Explain WhyOct 23 2016, 2:28 PM

This revision was automatically updated to reflect the committed changes.

The distinction between .bc and .bco was actually purposeful. The next step in the process is to add IR build rules for whole programs, and then we might end up with conflicts between the IR file that's analogous to cp.o and the IR file that's analogous to the cp binary (i.e., the result of llvm-link). So, we used .bco as the bitcode suffix that's analogous to .o (much like .pico is the PIC suffix for .o files).

That said, we might be ok if we stick to program IR names like cp.full.bc... we shall see. We may need to revisit this commit in the future.