brand_info on MIPS
ClosedPublic
Actions

Authored by br on Sep 15 2016, 3:59 PM.

Details

Reviewers

kib
brooks
emaste
jhb

Group Reviewers

MIPS

Commits

rS306187: Set the standard freebsd brand note for ELF binaries on MIPS,

Summary

set a standard brand info so applications on MIPS will get correct p_osrel

(without this patch p_osrel is 0, which is wrong)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br updated this revision to Diff 20368.Sep 15 2016, 3:59 PM

br retitled this revision from to brand_info on MIPS.

br updated this object.

br edited the test plan for this revision. (Show Details)

br added a reviewer: MIPS.

kib@ is probably the best one to look at this, but this does seem correct.

This revision is now accepted and ready to land.Sep 15 2016, 4:36 PM

Should the BI_CAN_EXEC_DYN flag also be set? It seems to be on the other architectures.

In D7899#163752, @andrew wrote:

Should the BI_CAN_EXEC_DYN flag also be set? It seems to be on the other architectures.

BI_CAN_EXEC_DYN actual meaning is the support for the PIE binaries. Does mips rtld handle them ? Generally all arches handle PIEs, but mips is the weirdest port with significant bugs in rtld part.

In D7899#163764, @kib wrote:

BI_CAN_EXEC_DYN actual meaning is the support for the PIE binaries. Does mips rtld handle them ? Generally all arches handle PIEs, but mips is the weirdest port with significant bugs in rtld part.

Brooks or Ed might know.

sbruno added a subscriber: sbruno.Sep 16 2016, 4:50 PM

Closed by commit rS306187: Set the standard freebsd brand note for ELF binaries on MIPS, (authored by br). · Explain WhySep 22 2016, 12:48 PM

This revision was automatically updated to reflect the committed changes.