Page MenuHomeFreeBSD
Differential D7724

Copy capabilities to new fd after accept(2).
ClosedPublic
Actions

Authored by oshogbo on Aug 31 2016, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 19, 12:47 AM
Unknown Object (File)
Fri, Oct 17, 4:20 PM
Unknown Object (File)
Wed, Oct 15, 6:01 PM
Unknown Object (File)
Wed, Oct 15, 6:01 PM
Unknown Object (File)
Wed, Oct 15, 6:01 PM
Unknown Object (File)
Wed, Oct 15, 6:01 PM
Unknown Object (File)
Wed, Oct 15, 6:01 PM
Unknown Object (File)
Wed, Oct 15, 6:01 PM
View All Files
Subscribers
allanjude

Details

Reviewers
drysdale_google.com
emaste
ed
jonathan
pjd
rwatson
Commits
rS306174: capsicum: propagate rights on accept(2)
Summary

Mailing list: https://lists.cam.ac.uk/pipermail/cl-capsicum-discuss/2016-August/msg00000.html
Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201052#add_comment

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

oshogbo updated this revision to Diff 19886.Aug 31 2016, 6:41 PM
oshogbo retitled this revision from to Copy capabilities to new fd after accept(2)..
oshogbo updated this object.
oshogbo edited the test plan for this revision. (Show Details)
oshogbo updated this object.Aug 31 2016, 7:09 PM
oshogbo added reviewers: ed, pjd, rwatson, emaste, jonathan, drysdale_google.com.
emaste added a subscriber: allanjude.Aug 31 2016, 7:10 PM
oshogbo updated this object.Aug 31 2016, 7:14 PM
emaste added inline comments.Aug 31 2016, 11:35 PM
sys/kern/uipc_syscalls.c
90–92 ↗(On Diff #19886)

can you update the comment to describe the new arg

oshogbo updated this revision to Diff 19952.Sep 1 2016, 7:58 PM
oshogbo changed the visibility from "All Users" to "Public (No Login Required)".

Add comment requested by emaste@.

emaste edited edge metadata.Sep 5 2016, 11:59 PM

I agree with the change but would still like to think about the locking some more

emaste added inline comments.Sep 6 2016, 6:14 PM
sys/kern/uipc_syscalls.c
121 ↗(On Diff #19952)

Discussed with oshogbo on IRC; we get here when havecaps != NULL and ioctls are encountered.

oshogbo updated this revision to Diff 20282.Sep 12 2016, 10:49 PM
oshogbo edited edge metadata.
oshogbo marked an inline comment as done.

After r305756 we can do that much simpler ;)

oshogbo updated this revision to Diff 20283.Sep 12 2016, 10:51 PM

I miss comment which was suggested by @emaste.

emaste added a comment.Sep 13 2016, 12:19 AM

Indeed, much more clear after rS305756

jonathan accepted this revision.Sep 21 2016, 7:27 PM
jonathan edited edge metadata.

Agreed: this change makes perfect sense to me after rS305756.

This revision is now accepted and ready to land.Sep 21 2016, 7:27 PM
Closed by commit rS306174: capsicum: propagate rights on accept(2) (authored by oshogbo). · Explain WhySep 22 2016, 9:59 AM
This revision was automatically updated to reflect the committed changes.
oshogbo marked an inline comment as done.

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
cloudabi/
2 lines
linux/
2 lines
kern/
2 lines
35 lines
netinet/
6 lines
sys/
3 lines

Diff 20608

View Options

head/sys/compat/cloudabi/cloudabi_sock.c

Loading...
View Options

head/sys/compat/linux/linux_socket.c

Loading...
View Options

head/sys/kern/kern_sendfile.c

Loading...
View Options

head/sys/kern/uipc_syscalls.c

Loading...
View Options

head/sys/netinet/sctp_syscalls.c

Loading...
View Options

head/sys/sys/socketvar.h

Loading...