Special handling for -o, open the fd before entering the sandbox, then set the mode on it later (the intended mode is specified in the input)
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5584 Build 5839: CI src build Jenkins Build 5838: arc lint + arc unit
Event Timeline
Comment Actions
Just some high level comments. I think if the diff is smaller, it's easier to review the rest.
| usr.bin/uudecode/uudecode.c | ||
|---|---|---|
| 83–85 | Why have this at all? We keep a dirfd around which can open outfile anyway — no need to open the file before entering sandbox. It duplicates the safe-output-file checking logic below, except for potential time-of-check vs time-of-use attacks. IMO, this whole function can be removed. | |
| 143–144 | I think in general we should preopen an array of fds rather than FILE objects, then fdopen as needed. (The concern is that the overhead of FILE objects vs fds is meaningful.) One potential cost is the size of the stdio buffering. I guess I would be a little shocked if FILE prefetched file contents or allocated much memory on open. But even so a FILE is bulkier than just an fd. | |
| 192–206 | I think you could avoid a lot of unnecessary code churn of this patch by setting globals infile, infp, (as is the existing pattern in this code) rather than passing these things as parameters. | |
Comment Actions
Use new capsicum_helpers.h
Greatly reduce the diff as suggested by cem
Address a bug where input is provided via stdin
Comment Actions
LGTM. I'd like to see restriction on cwdfd and openated child fds (if they don't inherit restrictions).
| usr.bin/uudecode/uudecode.c | ||
|---|---|---|
| 168 | And rights for fstatat and unlinkat. | |