Fix bug where malloc(.., M_NOWAIT) return value is not checked
ClosedPublic
Actions

Authored by sbruno on Aug 25 2016, 11:42 PM.

Details

Reviewers

kmacy
scottl
gallatin
shurd

Commits

rS307041: Fix bug where malloc(.., M_NOWAIT) return value is not checked, Change to

Summary

Change to M_WAITOK and move outside the mutex

Test Plan

Tested using bnxt driver, universe kernel build

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

shurd updated this revision to Diff 19701.Aug 25 2016, 11:42 PM

shurd retitled this revision from to Fix bug where malloc(.., M_NOWAIT) return value is not checked.

shurd updated this object.

shurd edited the test plan for this revision. (Show Details)

shurd added reviewers: kmacy, scottl.

Herald added a subscriber: imp. · View Herald TranscriptAug 25 2016, 11:42 PM

Add more reviewers

So, it looks like this should be committed. Objections?

sbruno accepted this revision.Oct 9 2016, 11:50 PM

sbruno edited edge metadata.

This revision is now accepted and ready to land.Oct 9 2016, 11:50 PM

Matt approved in LLNW IRC

sbruno commandeered this revision.Oct 11 2016, 2:07 PM

sbruno edited reviewers, added: shurd; removed: sbruno.

This revision now requires review to proceed.Oct 11 2016, 2:07 PM

Closed by commit rS307041: Fix bug where malloc(.., M_NOWAIT) return value is not checked, Change to (authored by sbruno). · Explain WhyOct 11 2016, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

subr_gtaskqueue.c

6 lines

Diff 21250

View Options

head/sys/kern/subr_gtaskqueue.c

Fix bug where malloc(.., M_NOWAIT) return value is not checkedClosedPublicActions