Create a TARGET_CPUARCH thing which fixes check-old after r302391.
ClosedPublic
Actions

Authored by bdrewery on Jul 8 2016, 7:28 PM.

Details

Reviewers

jhibbits
andrew
imp
• ian

Commits

rS302671: Create a TARGET_CPUARCH thing to go with MACHINE_CPUARCH.

Summary

MFC after: 3 days
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdrewery updated this revision to Diff 18227.Jul 8 2016, 7:28 PM

bdrewery retitled this revision from to Create a TARGET_CPUARCH thing which fixes check-old after r302391..

bdrewery updated this object.

bdrewery edited the test plan for this revision. (Show Details)

bdrewery added reviewers: imp, jhibbits, andrew, • ian.

bdrewery added a subscriber: gjb.

Herald added a subscriber: emaste. · View Herald TranscriptJul 8 2016, 7:28 PM

bdrewery added a parent revision: D7159: Create one list of replacements for MACHINE_CPUARCH as MACHINE_CPUARCH_SUB..Jul 8 2016, 7:28 PM

Still confused over the difference of ${TARGET} vs ${TARGET_CPUARCH}, and for that matter, as you said on IRC, ${MACHINE} vs ${MACHINE_CPUARCH}.

Looks fine, though.

This revision is now accepted and ready to land.Jul 8 2016, 7:37 PM

In D7160#148994, @jhibbits wrote:

Still confused over the difference of ${TARGET} vs ${TARGET_CPUARCH}, and for that matter, as you said on IRC, ${MACHINE} vs ${MACHINE_CPUARCH}.

Looks fine, though.

No clue, but we support all 3 for Makefiles at least via share/mk/bsd.arch.inc.mk:

.if exists(${.CURDIR}/Makefile.${MACHINE})
.include "Makefile.${MACHINE}"
.elif exists(${.CURDIR}/Makefile.${MACHINE_ARCH})
.include "Makefile.${MACHINE_ARCH}"
.elif exists(${.CURDIR}/Makefile.${MACHINE_CPUARCH})
.include "Makefile.${MACHINE_CPUARCH}"
.endif

This is no longer needed to fix 'check-old' after rS302449. It may still be useful though.

Closed by commit rS302671: Create a TARGET_CPUARCH thing to go with MACHINE_CPUARCH. (authored by bdrewery). · Explain WhyJul 12 2016, 6:57 PM

This revision was automatically updated to reflect the committed changes.