Page MenuHomeFreeBSD

Sync iwm against dfbsd
ClosedPublic

Authored by kbowling on Jun 26 2016, 6:10 AM.

Details

Summary

Large diff reduction to DragonFly BSD git 55a262956d059036136c7a461ddc79bff2f67363, adds 8260 support, updates everything to firmware version 16

Firmware patch necessary: http://kev009.com/freebsd/iwm-fw.patch

Test Plan

Test on iwm devices

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kbowling retitled this revision from to Sync iwm against dfbsd .
kbowling updated this object.
kbowling edited the test plan for this revision. (Show Details)
kbowling added reviewers: adrian, imre_vdsz.com, avos.
kbowling set the repository for this revision to rS FreeBSD src repository - subversion.
kbowling added a subscriber: sbruno.

It seems to go through 2 watchdog resets on boot while scanning/associating, then is fairly reliable. I've now passed a few gigabytes over the 8260 w/o hiccups.

sys/dev/iwm/if_iwm.c
1990 ↗(On Diff #17887)

This change is not needed (see rS298818 and rS299883)

pi removed a subscriber: pi.
pi added a subscriber: pi.

Address Andriy's comment on accidentally removing rS299883.

Bring in iwm_led callout stop change from https://lists.freebsd.org/pipermail/freebsd-wireless/2016-June/006805.html and ensure nothing is missed from Emmanuel Vadot's port, we did essentially the same thing but I left linux filename comments in, stripped dfbsd ifdefs.

avos edited edge metadata.

Looks fine for me (however, I have no device to test with).

sys/dev/iwm/if_iwm.c
4028 ↗(On Diff #17903)

Sure? tx->data_retry_limit/tx->rts_retry_limit + ic->ic_htprotmode should work better (just a note; now this code is noop anyway)

This revision is now accepted and ready to land.Jun 26 2016, 9:56 PM

I haven't looked at this patch in detail, but I thought I would point out the obvious, that manu's work changed some additional files required to update the firmware - as you alluded to in your original comment above:

  • Each of the firmware files locations in sys/contrib/dev/iwm/ were updated
  • Each of the Makefiles in the directory sys/modules/iwmfw and sub-directories, to register the new firmware file for iwm8000 and update the revision of the other firmware files.

https://github.com/freebsd/freebsd/compare/master...evadot:iwm

I haven't looked at this patch in detail, but I thought I would point out the obvious, that manu's work changed some additional files required to update the firmware - as you alluded to in your original comment above:

Please see the summary at the top of the review for the firmware patch. It is 10MB of data so I cannot upload it to Phabricator and the changes are pretty simple.

ok, I'll go commit some variant of this soon, piecemeal.

firmware update patch is in head now. How do we want to proceed here?

Does D5054 block this?

This revision was automatically updated to reflect the committed changes.

Woo, thank you!

Hopefully, this improves FreeBSD for you. Let me know if things aren't right.