Page MenuHomeFreeBSD

Deobfuscate cleanup path in clnt_bck_create(..)
ClosedPublic

Authored by ngie on Jun 10 2016, 3:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 19, 1:11 PM
Unknown Object (File)
Tue, Sep 8, 4:41 PM
Unknown Object (File)
Fri, Sep 4, 1:34 AM
Unknown Object (File)
Aug 24 2026, 12:59 AM
Unknown Object (File)
Aug 24 2026, 12:57 AM
Unknown Object (File)
Aug 19 2026, 9:15 PM
Unknown Object (File)
Aug 14 2026, 1:26 AM
Unknown Object (File)
Jul 18 2026, 1:17 PM

Details

Reviewers
cem
Summary

Deobfuscate cleanup path in clnt_bck_create(..)

Similar to r300836, cl and ct will always be non-NULL as they're allocated
using the mem_alloc routines, which always use malloc(..., M_WAITOK) .

Deofuscating the cleanup path fixes a leak where if cl was NULL and
ct was not, ct would not be free'd, and also removes a duplicate test for
cl not being NULL.

MFC after: 1 week
Reported by: Coverity
CID: 1229999
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4174
Build 4217: arc lint + arc unit

Event Timeline

ngie retitled this revision from to Deobfuscate cleanup path in clnt_bck_create(..).
ngie updated this object.
ngie edited the test plan for this revision. (Show Details)
ngie added subscribers: markj, pfg, rmacklem, cem.
cem added a reviewer: cem.
This revision is now accepted and ready to land.Jun 10 2016, 3:43 PM