Page MenuHomeFreeBSD
Differential D6578

if.c: no need for trylock
ClosedPublic
Actions

Authored by bz on May 26 2016, 1:48 PM.
Tags
None
Referenced Files
F152994493: D6578.id16907.diff
Sat, Apr 18, 12:57 PM
Unknown Object (File)
Sat, Apr 11, 7:04 AM
Unknown Object (File)
Tue, Apr 7, 3:49 PM
Unknown Object (File)
Tue, Apr 7, 10:58 AM
Unknown Object (File)
Mon, Apr 6, 7:10 AM
Unknown Object (File)
Sun, Apr 5, 4:46 PM
Unknown Object (File)
Sun, Apr 5, 2:06 AM
Unknown Object (File)
Sat, Mar 28, 11:35 PM
View All Files
Subscribers
imp
network

Details

Reviewers
markj
gnn
rwatson
Commits
rS300901: In if_attachdomain1() there does not seem to be any reason
Summary

In if_attachdomain1() there does not seem to be any reason
to use TRYLOCK rather than just acquire the lock.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz updated this revision to Diff 16907.May 26 2016, 1:48 PM
bz retitled this revision from to if.c: no need for trylock.
bz updated this object.
bz edited the test plan for this revision. (Show Details)
bz added reviewers: gnn, markj, rwatson.
bz set the repository for this revision to rS FreeBSD src repository - subversion.
bz added a subscriber: network.
Herald added a subscriber: imp. · View Herald TranscriptMay 26 2016, 1:48 PM
markj accepted this revision.May 26 2016, 8:28 PM
markj edited edge metadata.

LGTM. I can't see any reason based on the history of the change that introduced this.

This revision is now accepted and ready to land.May 26 2016, 8:28 PM
Closed by commit rS300901: In if_attachdomain1() there does not seem to be any reason (authored by bz). · Explain WhyMay 28 2016, 8:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net/
3 lines

Diff 17025

View Options

head/sys/net/if.c

Loading...