if.c: no need for trylock
ClosedPublic
Actions

Authored by bz on May 26 2016, 1:48 PM.

Tags

None

Referenced Files

	F173359302: D6578.id16907.diff
	Fri, Sep 25, 10:45 AM

	Unknown Object (File)
	Wed, Sep 23, 11:39 AM

	Unknown Object (File)
	Sat, Sep 19, 12:51 AM

	Unknown Object (File)
	Thu, Sep 17, 7:18 AM

	Unknown Object (File)
	Thu, Sep 17, 7:18 AM

	Unknown Object (File)
	Thu, Sep 17, 7:15 AM

	Unknown Object (File)
	Sat, Aug 29, 3:02 AM

	Unknown Object (File)
	Fri, Aug 28, 11:32 PM

View All Files

Subscribers

imp

network

Details

Reviewers

markj
gnn
rwatson

Commits

rS300901: In if_attachdomain1() there does not seem to be any reason

Summary

In if_attachdomain1() there does not seem to be any reason
to use TRYLOCK rather than just acquire the lock.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz updated this revision to Diff 16907.May 26 2016, 1:48 PM

bz retitled this revision from to if.c: no need for trylock.

bz updated this object.

bz edited the test plan for this revision. (Show Details)

bz added reviewers: gnn, markj, rwatson.

bz set the repository for this revision to rS FreeBSD src repository - subversion.

bz added a subscriber: network.

Herald added a subscriber: imp. · View Herald TranscriptMay 26 2016, 1:48 PM

LGTM. I can't see any reason based on the history of the change that introduced this.

This revision is now accepted and ready to land.May 26 2016, 8:28 PM

Closed by commit rS300901: In if_attachdomain1() there does not seem to be any reason (authored by bz). · Explain WhyMay 28 2016, 8:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if.c

3 lines

Diff 17025

View Options

if.c: no need for trylockClosedPublicActions