Page MenuHomeFreeBSD
Differential D6155

Add STATIC option to x11-fonts/fontconfig
ClosedPublic
Actions

Authored by cy on Apr 30 2016, 5:22 AM.
Tags
None
Referenced Files
F153724751: D6155.diff
Thu, Apr 23, 6:02 AM
Unknown Object (File)
Mon, Apr 20, 12:39 AM
Unknown Object (File)
Fri, Apr 17, 12:14 PM
Unknown Object (File)
Fri, Apr 17, 12:09 PM
Unknown Object (File)
Thu, Apr 16, 11:25 PM
Unknown Object (File)
Mon, Apr 13, 4:38 AM
Unknown Object (File)
Sun, Apr 12, 6:09 PM
Unknown Object (File)
Mar 15 2026, 12:17 PM
View All Files
Subscribers
bapt
dumbbell
kwm
mat
zeising
gnome
x11

Details

Reviewers
dumbbell
marcus
cem
wblock
kwm
mat
Commits
rP414575: Link static library.
Summary

I h ave a requirement to statically link x11/xforward. Unfortunately x11-fonts/fontconfig does not install static (.a) libraries. The patch in this differential revision adds the option to install a static libfontconfig.a library.

Test Plan

A new x11/xforward-static port has been created locally and tested using a locally updated x11/fontconfig port with ENABLE_STATIC on my firewall/gateway, which does not have X installed. The test has passed.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cy updated this revision to Diff 15755.Apr 30 2016, 5:22 AM
cy retitled this revision from to Add ENABLE_STATIC option to x11-fonts/fontconfig.
cy updated this object.
cy edited the test plan for this revision. (Show Details)
cy added reviewers: marcus, cem, wblock.
cy set the repository for this revision to rP FreeBSD ports repository.
cy added a subscriber: gnome.
Herald added a subscriber: mat. · View Herald TranscriptApr 30 2016, 5:22 AM
kwm added a subscriber: kwm.May 1 2016, 5:22 PM
kwm added inline comments.
x11-fonts/fontconfig/Makefile
43 ↗(On Diff #15755)

Could you rename the option to STATIC? OPTIONS already implies enable/disable.

44 ↗(On Diff #15755)

When renamed this lines can be removed, as the STATIC define is in bsd.options.desc.mk.

45 ↗(On Diff #15755)

STATIC_CONFIGURE_ENABLE=static

cy updated this revision to Diff 15805.May 1 2016, 10:30 PM
cy retitled this revision from Add ENABLE_STATIC option to x11-fonts/fontconfig to Add STATIC option to x11-fonts/fontconfig.
cy marked an inline comment as done.

Changed ENABLE_STATIC to STATIC.

cy added reviewers: mat, kwm.May 1 2016, 10:32 PM
cy added a subscriber: x11.
cy updated this revision to Diff 15806.May 1 2016, 11:00 PM

STATIC_CONFIGURE_ENABLE= also set

dumbbell added a subscriber: dumbbell.May 2 2016, 7:35 AM

Do we really need an option? Can't the port always install the static library?

bapt added a subscriber: bapt.May 2 2016, 8:07 AM
In D6155#131417, @dumbbell wrote:

Do we really need an option? Can't the port always install the static library?

/me 100% agrees

zeising added a subscriber: zeising.May 2 2016, 8:28 AM
In D6155#131419, @bapt wrote:
In D6155#131417, @dumbbell wrote:

Do we really need an option? Can't the port always install the static library?

/me 100% agrees

I also agree with this. I see no need to have a separate option for this.
Other than that, I see no problem in approving this.

cy updated this revision to Diff 15839.May 3 2016, 3:14 AM

Sure, static it is.

cy added a comment.May 3 2016, 3:15 AM

If people are happy with this, I'll commit it and move onto xforward.

dumbbell accepted this revision.May 3 2016, 6:32 AM
dumbbell added a reviewer: dumbbell.
This revision is now accepted and ready to land.May 3 2016, 6:32 AM
kwm edited edge metadata.May 3 2016, 8:42 AM

Yeah this is fine too. Could you add a comment though why static is enabled? Otherwise someone might remove it in a future updated (probably me..).

Closed by commit rP414575: Link static library. (authored by cy). · Explain WhyMay 4 2016, 2:45 AM
This revision was automatically updated to reflect the committed changes.
cy mentioned this in rP414575: Link static library..

Revision Contents
Changeset List

PathSize
head/
x11-fonts/
fontconfig/
5 lines
1 line

Diff 15880

View Options

head/x11-fonts/fontconfig/Makefile

Loading...
View Options

head/x11-fonts/fontconfig/pkg-plist

Loading...