archivers/arc: Update CONFLICTS_INSTALL
ClosedPublic
Actions

Authored by dteske on Fri, Oct 30, 1:02 AM.

Project Tags

None

Referenced Files

	F176843215: D61002.1793478857.diff
	Fri, Oct 30, 8:34 PM

	F176843085: D61002.1793478431.diff
	Fri, Oct 30, 8:27 PM

	F176842907: D61002.1793477821.diff
	Fri, Oct 30, 8:17 PM

	F176817103: D61002.1793420782.diff
	Fri, Oct 30, 4:26 AM

	F176817043: D61002.1793420640.diff
	Fri, Oct 30, 4:24 AM

Subscribers

Details

Reviewers

Commits

R11:8516acc01441: archivers/arc: Update CONFLICTS_INSTALL

Summary

Add phorgeit-arcanist-php[0-9][0-9] to CONFLICTS_INSTALL

While here, satisfy portclippy and portfmt -D

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

dteske requested review of this revision.Fri, Oct 30, 1:02 AM

dteske created this revision.

LGTM, but I'm not the maintainer (@delphij is).

This revision is now accepted and ready to land.Fri, Oct 30, 1:04 AM

In D61002#1398836, @ngie wrote:

LGTM, but I'm not the maintainer (@delphij is).

Thanks for adding the maintainer. Good call. An oversight on my part.

archivers/arc/Makefile
3	I missed that this probably needs to be bumped.

archivers/arc/Makefile
3	Precisely why I raised the review and I wanted @fuz and/or @jrm to weigh-in here. Technically speaking, CONFLICTS_INSTALL doesn't get encoded into the compiled package, so in this particular case (wherein the only change is to CONFLICTS_INSTALL), a compiled package under this Makefile and previous are identical in every way. The porters handbook specifically says build conflicts stay out of the package. Checking the MANIFEST of a compiled package confirms that build conflicts don't influence the package contents.

archivers/arc/Makefile
3	Precisely why I raised the review and I wanted @fuz and/or @jrm to weigh-in here. Technically speaking, CONFLICTS_INSTALL doesn't get encoded into the compiled package, so in this particular case (wherein the only change is to CONFLICTS_INSTALL), a compiled package under this Makefile and previous are identical in every way. The porters handbook specifically says build conflicts stay out of the package. Checking the MANIFEST of a compiled package confirms that build conflicts don't influence the package contents. Hm. Yeah, please drop this comment thread makes a note to go back and read the Porter's Handbook.