dwmmc: Add HS200 support
Needs ReviewPublic
Actions

Authored by manu on Tue, Oct 20, 9:03 AM.

Details

Reviewers

andrew
mmel

Group Reviewers

arm64

Summary

Add the tuning procedure (CMD21 with the standard JEDEC tuning block
patterns), the 1.2V/1.8V/3.3V signaling voltage switch using voltage
bands, a watchdog for stuck requests, controller recovery and DMA fixes
needed to run HS200 reliably.

For the Rockchip glue, implement the tuning hook by sweeping the sample
clock phase over 360 degrees, picking the middle of the widest good window
and restoring the previous phase on failure. The drive phase is set to
180 degrees.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78401
Build 75284: arc lint + arc unit

Event Timeline

manu created this revision.Tue, Oct 20, 9:03 AM

Herald added a reviewer: andrew. · View Herald TranscriptTue, Oct 20, 9:03 AM

Herald added a subscriber: imp. · View Herald Transcript

manu requested review of this revision.Tue, Oct 20, 9:03 AM

Harbormaster completed remote builds in B78391: Diff 190363.Tue, Oct 20, 9:03 AM

manu added a parent revision: D60887: clk: rockchip: rk3328: Add the MMC sample and drive clocks.Tue, Oct 20, 9:03 AM

manu added a child revision: D60889: sdhci: rockchip: Enable HS200 on the RK3399.

manu added reviewers: arm64, mmel.Tue, Oct 20, 9:03 AM

mmel added inline comments.Tue, Oct 20, 9:46 AM

sys/dev/mmc/host/dwmmc.c
1028	How can we recover from this BUSDMA error? Imho, this is always a programming error rather than an operational failure, so panic is more appropriate.
1173	Does this work even if the cttrl + card are switched to a lower voltage??
1197	Please put these defines at the top
1368	It must be panic. This is not recoverable.

manu added inline comments.Tue, Oct 20, 10:22 AM

sys/dev/mmc/host/dwmmc.c
1028	I'll restore the panic
1173	Yes, I needed it for tuning on rock64 which happens at 1.8V, just the voltage is never touch. Now if the question is "will it work on every condition ?" I'm pretty sure that the answer is no :)
1197	will do
1368	Mhm yes but before it was a hang as the loop never stopped, now it's better and honestly not sure if this will be recoverable or not depending on the conditions.