Page MenuHomeFreeBSD

sdhci: rockchip: Enable HS200 on the RK3399
AcceptedPublic

Authored by manu on Tue, Oct 20, 9:03 AM.
Tags
None
Referenced Files
F176702441: D60889.id190364.diff
Tue, Oct 20, 9:54 PM
F176700219: D60889.id190365.diff
Tue, Oct 20, 9:29 PM
F176700004: D60889.diff
Tue, Oct 20, 9:26 PM
F176695423: D60889.id190365.diff
Tue, Oct 20, 8:36 PM
F176671033: D60889.id190364.diff
Tue, Oct 20, 5:42 PM
F176664381: D60889.id190365.diff
Tue, Oct 20, 4:45 PM
F176658880: D60889.diff
Tue, Oct 20, 3:39 PM
F176646538: D60889.diff
Tue, Oct 20, 1:03 PM
Subscribers

Details

Reviewers
mmel
Group Reviewers
arm64
Summary

Pin the xin clock to 200MHz, use the generic UHS timing and tuning
methods, parse the eMMC properties and the vqmmc supply from the device
tree, and set the I/O voltage through the regulator framework instead of
the S18 bit. Limit the RockPro64 to 100MHz.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 78393
Build 75276: arc lint + arc unit

Event Timeline

manu requested review of this revision.Tue, Oct 20, 9:03 AM
sys/dev/sdhci/sdhci_fdt_rockchip.c
299

rounding should be used - clk_set_freq(sc->clk_xin, 200000000, CLK_SET_ROUND_DOWN);

308

It is expected that the CRU can always produce the exact frequency. If so, the clk_set_freq() should use the CLK_SET_ROUND_EXACT.

324

helper is part of softc, thus cleared

manu marked 3 inline comments as done.Tue, Oct 20, 9:33 AM
This revision is now accepted and ready to land.Tue, Oct 20, 9:51 AM