Page MenuHomeFreeBSD
Differential D60524

x86: Add external retpoline thunk
ClosedPublic
Actions

Authored by emaste on Fri, Oct 9, 2:06 PM.
Tags
None
Referenced Files
F175749589: D60524.id189246.diff
Tue, Oct 13, 12:46 AM
F175676247: D60524.id189246.diff
Mon, Oct 12, 11:03 AM
F175663394: D60524.id189239.diff
Mon, Oct 12, 8:56 AM
F175653147: D60524.id.diff
Mon, Oct 12, 7:26 AM
F175650385: D60524.diff
Mon, Oct 12, 7:04 AM
Unknown Object (File)
Sun, Oct 11, 2:28 PM
Unknown Object (File)
Sun, Oct 11, 10:15 AM
Unknown Object (File)
Sun, Oct 11, 6:30 AM
View All 21 Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rG74d971fe1561: x86: Add external retpoline thunk
Summary
This allows use of -mindirect-branch=thunk-extern, and is only a few
bytes of dead code if not used.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Fri, Oct 9, 2:06 PM
emaste created this revision.
kib accepted this revision.Fri, Oct 9, 2:45 PM
kib added inline comments.
sys/i386/i386/support.S
590

why 'retpoline' starts with lower 'r'? Or why amd64 variant starts with the upper?

This revision is now accepted and ready to land.Fri, Oct 9, 2:45 PM
emaste added inline comments.Fri, Oct 9, 2:48 PM
sys/i386/i386/support.S
590

Unsure. Lower r is probably correct (retpoline is a word coined for this specific purpose, but is not a proper noun), I will update before pushing.

Closed by commit rG74d971fe1561: x86: Add external retpoline thunk (authored by emaste). · Explain WhyFri, Oct 9, 2:51 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG74d971fe1561: x86: Add external retpoline thunk.
Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 2:51 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
10 lines
i386/
i386/
10 lines

Diff 189246

View Options

sys/amd64/amd64/support.S

Loading...
View Options

sys/i386/i386/support.S

Loading...