Page MenuHomeFreeBSD

Remove kvm_getfiles(3)
ClosedPublic

Authored by ngie on Apr 21 2016, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 11:33 AM
Unknown Object (File)
Jan 31 2024, 2:08 PM
Unknown Object (File)
Jan 27 2024, 12:32 PM
Unknown Object (File)
Dec 23 2023, 4:26 AM
Unknown Object (File)
Dec 19 2023, 11:33 PM
Unknown Object (File)
Dec 19 2023, 10:40 AM
Unknown Object (File)
Dec 14 2023, 2:20 PM
Unknown Object (File)
Nov 13 2023, 5:49 PM

Details

Reviewers
markj
jhb
Group Reviewers
manpages
Summary

Remove kvm_getfiles(3)

This libcall has been broken since r174989/8.0-RELEASE.

Bump SHLIB_MAJOR for the change (and the cross-architecture support added
by jhb in r297359).

Differential Revision: https://reviews.freebsd.org/D6052
Relnotes: yes
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ngie retitled this revision from to Remove kvm_getfiles(3).
ngie updated this object.
ngie edited the test plan for this revision. (Show Details)
ngie set the repository for this revision to rS FreeBSD src repository - subversion.
ngie added subscribers: jhb, markj, araujo, pfg.

Adding this diff to ObsoleteFiles.inc:

$ git diff ObsoleteFiles.inc 
diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
index 5f29f4b..bd30ac0 100644
--- a/ObsoleteFiles.inc
+++ b/ObsoleteFiles.inc
@@ -38,6 +38,8 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
+OLD_LIBS+=usr/lib/libkvm.so.6
+OLD_FILES+=usr/share/man/man3/kvm_getfiles.3.gz
 # 20160317: rman_res_t size bump to uintmax_t
 OLD_LIBS+=usr/lib/libdevinfo.so.5
 OLD_LIBS+=usr/lib32/libdevinfo.so.5
lib/libkvm/kvm.3
144

Reminder: update .Dd

ngie marked an inline comment as done.
ngie edited edge metadata.
  • Add ObsoleteFiles.inc entries
  • Bump .Dd
ngie edited edge metadata.
In D6052#128849, @ngie wrote:
  • Add ObsoleteFiles.inc entries
  • Bump .Dd

The kvm.h change got pulled by accident when I rebased my branches.. It'll be in the final diff.

Readd kvm.h portion of the diff

I would not MFC this but only change it in HEAD.

I think it is useful to note how long it has been marked broken in the commit log. It was first marked broken in rS174989. Maybe note the oldest release that had a functional kvm_getfiles() as well.

lib/libkvm/Makefile
7

Humm, I thought I had already done this, but I guess I didn't.

ngie edited edge metadata.
In D6052#129075, @jhb wrote:

I would not MFC this but only change it in HEAD.

I think it is useful to note how long it has been marked broken in the commit log. It was first marked broken in rS174989. Maybe note the oldest release that had a functional kvm_getfiles() as well.

I totally agree.

jhb added a reviewer: jhb.

Fine with me. No need to mention the cross-arch stuff in the commit. I actually did that in such a way to avoid a version bump (hence kvm_read2 and kvm_nlist2).

This revision is now accepted and ready to land.Apr 29 2016, 4:52 PM
markj added a reviewer: markj.