Page MenuHomeFreeBSD

sound: Hold the topology lock across dsp_oss_audioinfo()
Needs ReviewPublic

Authored by christos on Thu, Oct 8, 1:10 PM.
Tags
None
Referenced Files
F175196558: D60466.diff
Fri, Oct 9, 12:48 AM
F175188659: D60466.diff
Thu, Oct 8, 11:25 PM
F175161107: D60466.diff
Thu, Oct 8, 6:36 PM
Subscribers

Details

Reviewers
markj
emaste
kib
Summary

dsp_oss_audioinfo() drops the topology lock and then dereferences the
softc, which device_detach() may have freed in the meantime.

Hold the topology lock for the whole function, like the other
SNDCTL_*INFO handlers do. Busying the device instead is not an option,
because dsp_ioctl() has already busied the one the ioctl was issued on,
which may be the same.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77848
Build 74731: arc lint + arc unit