Differential D59791

ixl: Initialize the extended RSS key
ClosedPublic
Actions

Authored by kbowling on Fri, Sep 18, 8:31 AM.

Tags

None

Referenced Files

	F172956113: D59791.id187034.diff
	Tue, Sep 22, 9:42 AM

	F172861956: D59791.id187034.diff
	Mon, Sep 21, 4:23 PM

	F172860085: D59791.id187034.diff
	Mon, Sep 21, 4:05 PM

	Unknown Object (File)
	Sun, Sep 20, 5:33 PM

	Unknown Object (File)
	Sun, Sep 20, 2:32 AM

	Unknown Object (File)
	Sun, Sep 20, 2:31 AM

	Unknown Object (File)
	Sun, Sep 20, 2:31 AM

	Unknown Object (File)
	Sun, Sep 20, 2:00 AM

View All 12 Files

Subscribers

Details

Reviewers

Group Reviewers

Intel Networking
Restricted Owners Package	(Owns No Changed Paths)

Commits

rG0f7bdeadaf9d: ixl: Initialize the extended RSS key

Summary

Zero the complete 52-byte RSS key buffer before fetching the common
40-byte key.  Both the X722 AdminQ path and the register path consume all
52 bytes; the trailing extended-key bytes must not come from uninitialized
stack storage.  This matches the zero padding already used by iavf and ice.

Remove the unused driver-default key helper and its declaration.  Keep
the standard key, hash selections, and indirection policy unchanged.

MFC after:      2 weeks
Sponsored by:   BBOX.io

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling created this revision.Fri, Sep 18, 8:31 AM

Owners added a reviewer: Restricted Owners Package.Fri, Sep 18, 8:31 AM

Herald added subscribers: ae, imp. · View Herald TranscriptFri, Sep 18, 8:31 AM

kbowling requested review of this revision.Fri, Sep 18, 8:31 AM

gallatin accepted this revision.Fri, Sep 18, 8:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Sep 18, 10:49 PM

Closed by commit rG0f7bdeadaf9d: ixl: Initialize the extended RSS key (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG0f7bdeadaf9d: ixl: Initialize the extended RSS key.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

1 line

2 lines

17 lines

Diff 187163

sys/dev/ixl/ixl.h

Loading...

sys/dev/ixl/ixl_pf_main.c

Loading...

sys/dev/ixl/ixl_txrx.c

Loading...