Page MenuHomeFreeBSD
Differential D59733

LinuxKPI: implement __UNIQUE_ID() macro
AcceptedPublic
Actions

Authored by wulf on Wed, Sep 16, 5:38 PM.
Tags
None
Referenced Files
F172220474: D59733.id186894.diff
Wed, Sep 16, 11:30 PM
F172220448: D59733.id186916.diff
Wed, Sep 16, 11:30 PM
F172219173: D59733.diff
Wed, Sep 16, 11:11 PM
F172214377: D59733.id186894.diff
Wed, Sep 16, 10:12 PM
F172214288: D59733.id186916.diff
Wed, Sep 16, 10:11 PM
F172214192: D59733.diff
Wed, Sep 16, 10:10 PM
Subscribers
imp
linuxkpi

Details

Reviewers
bz
emaste
dumbbell
Summary

Requred by drm-kmod v6.12.103

Obtained from: OpenBSD

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76999
Build 73882: arc lint + arc unit

Event Timeline

wulf created this revision.Wed, Sep 16, 5:38 PM
Herald added subscribers: linuxkpi, imp. · View Herald TranscriptWed, Sep 16, 5:38 PM
wulf requested review of this revision.Wed, Sep 16, 5:38 PM
Harbormaster completed remote builds in B76983: Diff 186894.Wed, Sep 16, 5:38 PM
emaste accepted this revision.Wed, Sep 16, 5:45 PM
emaste added inline comments.
sys/compat/linuxkpi/common/include/linux/compiler.h
100–102

Do we have any compilers that don't provide __COUNTER__?
We can perhaps just omit this.

This revision is now accepted and ready to land.Wed, Sep 16, 5:45 PM
bz requested changes to this revision.Wed, Sep 16, 7:37 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/compiler.h
100–102

We are using __COUNTER__ elsewhere in LinuxKPI (and sys/sys) unconditionally. So this should really go away.

104

Linux documents the format as: __UNIQUE_ID_<name>_<__COUNTER__>

This revision now requires changes to proceed.Wed, Sep 16, 7:37 PM
emaste added inline comments.Wed, Sep 16, 7:48 PM
sys/compat/linuxkpi/common/include/linux/compiler.h
104

I was thinking it doesn't really matter, but I suppose it is worth putting it into some __ namespace to avoid possible conflict with a real symbol.

wulf updated this revision to Diff 186916.Wed, Sep 16, 8:44 PM

Add __UNIQUE_ID_ prefix per @bz request

Harbormaster completed remote builds in B76999: Diff 186916.Wed, Sep 16, 8:44 PM
emaste accepted this revision.Wed, Sep 16, 9:20 PM
bz accepted this revision.Wed, Sep 16, 9:51 PM
This revision is now accepted and ready to land.Wed, Sep 16, 9:51 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
4 lines

Diff 186916

View Options

sys/compat/linuxkpi/common/include/linux/compiler.h

Loading...