shmfd: consistently return size in 512 byte blocks for fstat st_blocks
ClosedPublic
Actions

Authored by kib on Wed, Aug 19, 2:33 AM.

Tags

None

Referenced Files

	F171105285: D58942.id184362.diff
	Tue, Sep 8, 5:44 PM

	F171053587: D58942.id184303.diff
	Tue, Sep 8, 10:32 AM

	Unknown Object (File)
	Tue, Sep 8, 5:06 AM

	Unknown Object (File)
	Tue, Sep 8, 3:59 AM

	Unknown Object (File)
	Sun, Sep 6, 10:22 AM

	Unknown Object (File)
	Sun, Sep 6, 8:05 AM

	Unknown Object (File)
	Sat, Sep 5, 9:25 AM

	Unknown Object (File)
	Sat, Sep 5, 3:35 AM

Subscribers

Details

Reviewers

markj
emaste

Commits

rG3a1bf59d195c: shmfd: consistently return size in 512 byte blocks for fstat(2) st_blocks

Summary

This is ABI-breaking change that could be considered as the bug fix.

Requested by: David Timber <dxdt@dev.snart.me>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Wed, Aug 19, 2:33 AM

Herald added subscribers: ziaee, olce, glebius, imp. · View Herald TranscriptWed, Aug 19, 2:33 AM

kib requested review of this revision.Wed, Aug 19, 2:33 AM

This revision is now accepted and ready to land.Wed, Aug 19, 2:45 AM

This needs a release note.

Closed by commit rG3a1bf59d195c: shmfd: consistently return size in 512 byte blocks for fstat(2) st_blocks (authored by kib). · Explain WhyWed, Aug 19, 2:47 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG3a1bf59d195c: shmfd: consistently return size in 512 byte blocks for fstat(2) st_blocks.

I think this breaks the accounting test in tests/sys/posixshm/posixshm_test.c.

Revision Contents
Changeset List

Path

Size

lib/

libsys/

stat.2

8 lines

sys/

kern/

uipc_shm.c

8 lines

Diff 184362

View Options

lib/libsys/stat.2