Page MenuHomeFreeBSD

unionfs_lock(): eliminate LK_CANRECURSE special-case
AcceptedPublic

Authored by jah on Sat, Aug 15, 4:18 PM.
Tags
None
Referenced Files
F166718548: D58858.id184096.diff
Sat, Aug 15, 8:45 PM
F166708620: D58858.id184096.diff
Sat, Aug 15, 7:48 PM
F166708402: D58858.diff
Sat, Aug 15, 7:47 PM
F166705278: D58858.diff
Sat, Aug 15, 7:15 PM
F166698883: D58858.diff
Sat, Aug 15, 5:21 PM
Subscribers

Details

Reviewers
kib
markj
olce
pho
Summary

As of commit 9f5c4ef328 ("dounmount(9): temporarily enable recursion
for the covered vnode lock"), the unmount path handles recursion
automatically, so there's no longer a need to handle this case
in unionfs-specific code.

dounmount(): generalize comment on covered vnode lock recursion

The need for recursion applies (in somewhat different form) to both
nullfs and unionfs, and would likely apply to any other hypothetical
stacked filesystem as well.

unionfs_noderem(): fix typo

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 75608
Build 72491: arc lint + arc unit

Event Timeline

jah requested review of this revision.Sat, Aug 15, 4:18 PM
This revision is now accepted and ready to land.Sat, Aug 15, 9:50 PM

I ran the unions test cases in a loop for 7 hours, with this patch.
Looks good to me.