Page MenuHomeFreeBSD
Differential D58781

makefs: Allow "legacy" as a valid ZFS mountpoint
ClosedPublic
Actions

Authored by jlduran on Tue, Aug 11, 3:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 11, 10:49 PM
Unknown Object (File)
Tue, Aug 11, 10:49 PM
Unknown Object (File)
Tue, Aug 11, 6:25 PM
Subscribers
delphij
imp

Details

Reviewers
senguptaangshuman17_gmail.com
imp
markj
Commits
rG59d6422d6f21: makefs: Allow "legacy" as a valid ZFS mountpoint
Summary

Allow "legacy" alongside "none" as a valid value for the ZFS mountpoint
property, matching zfsprops(7).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran created this revision.Tue, Aug 11, 3:10 AM
Herald added subscribers: delphij, imp. · View Herald TranscriptTue, Aug 11, 3:10 AM
jlduran requested review of this revision.Tue, Aug 11, 3:10 AM
Harbormaster completed remote builds in B75513: Diff 183860.Tue, Aug 11, 3:10 AM
jlduran added a reviewer: senguptaangshuman17_gmail.com.Tue, Aug 11, 3:11 AM
jlduran added a comment.Tue, Aug 11, 3:14 AM

We are still pondering if NanoBSD's /cfg partition, when using ZFS, should be legacy. At any rate, let's allow makefs(8) to create legacy mountpoints.

imp accepted this revision.Tue, Aug 11, 3:47 AM
This revision is now accepted and ready to land.Tue, Aug 11, 3:47 AM
imp added a reviewer: markj.Tue, Aug 11, 6:21 PM
markj accepted this revision.Tue, Aug 11, 6:31 PM
markj added inline comments.
usr.sbin/makefs/tests/makefs_zfs_tests.sh
688
jlduran added inline comments.Tue, Aug 11, 6:37 PM
usr.sbin/makefs/tests/makefs_zfs_tests.sh
650

@markj I'll change this one as well. Thanks

Closed by commit rG59d6422d6f21: makefs: Allow "legacy" as a valid ZFS mountpoint (authored by jlduran). · Explain WhyTue, Aug 11, 10:35 PM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rG59d6422d6f21: makefs: Allow "legacy" as a valid ZFS mountpoint.
jlduran marked an inline comment as done.Tue, Aug 11, 10:36 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
makefs/
tests/
39 lines
zfs/
5 lines

Diff 183900

View Options

usr.sbin/makefs/tests/makefs_zfs_tests.sh

Loading...
View Options

usr.sbin/makefs/zfs/dsl.c

Loading...