linux: Add STF type and convert some if_type to ARPHRD
ClosedPublic
Actions

Authored by pouria on Jul 31 2026, 2:31 PM.

Details

Reviewers

kib
glebius
dteske
emaste
kfv

Group Reviewers

network
emulation

Commits

rGba27b63c4477: linux: Add STF type and convert some if_type to ARPHRD

Summary

Convert IFT_BRIDGE and IFT_L2VLAN to ARPHRD_ETHER, and IFT_LOOP
to ARPHRD_LOOPBACK in linux netlink.
Also, add ARPHRD_SIT and convert IFT_STF to it.

Test Plan

test ip link show under linux compat:

root@ftsr1:/# ip link sh stf0
16: stf0: <> mtu 1280 qdisc noqueue state DOWN qlen 1000
link/sit
root@ftsr1:/# ip link sh vlan0
15: vlan0@bridge0: <BROADCAST,MULTICAST> mtu 1496 qdisc noqueue state UNKNOWN qlen 1000
link/ether 58:9c:fc:10:8c:9b brd ff:ff:ff:ff:ff:ff
root@ftsr1:/# ip link sh bridge0
12: bridge0: <BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state UP qlen 1000
link/ether 58:9c:fc:10:8c:9b brd ff:ff:ff:ff:ff:ff

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pouria created this revision.Jul 31 2026, 2:31 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 31 2026, 2:31 PM

pouria requested review of this revision.Jul 31 2026, 2:31 PM

Harbormaster completed remote builds in B75315: Diff 183159.Jul 31 2026, 2:31 PM

pouria edited the test plan for this revision. (Show Details)Jul 31 2026, 2:34 PM

pouria edited the test plan for this revision. (Show Details)

ping @kib

pouria added reviewers: dteske, emaste.Thu, Aug 13, 7:33 AM

pouria added a reviewer: kfv.Wed, Aug 19, 6:24 PM

Looks good to me, but while you're here, could we also map IFT_LOOP -> LINUX_ARPHRD_LOOPBACK so a Linux ip link show lo under the linuxulator does not look like FireWire? The constant already exists. Fine as a follow-up if you want to keep this patch to bridge/vlan/stf.

This revision is now accepted and ready to land.Wed, Aug 19, 6:51 PM

Address @kfv comment. Thanks!

This revision now requires review to proceed.Wed, Aug 19, 7:02 PM

Harbormaster completed remote builds in B75747: Diff 184376.Wed, Aug 19, 7:02 PM

kfv accepted this revision.Wed, Aug 19, 7:05 PM

This revision is now accepted and ready to land.Wed, Aug 19, 7:05 PM

pouria retitled this revision from linux: Add STF type and convert if_bridge and if_vlan to ARPHRD_ETHER to linux: Add STF type and convert some if_type to ARPHRD.Wed, Aug 19, 7:06 PM

pouria edited the summary of this revision. (Show Details)

Closed by commit rGba27b63c4477: linux: Add STF type and convert some if_type to ARPHRD (authored by pouria). · Explain WhyWed, Aug 19, 7:08 PM

This revision was automatically updated to reflect the committed changes.

pouria added a commit: rGba27b63c4477: linux: Add STF type and convert some if_type to ARPHRD.