Page MenuHomeFreeBSD

routing: Remove unused rib_head members
ClosedPublic

Authored by pouria on Wed, Jul 29, 5:57 PM.
Tags
None
Referenced Files
F167463785: D58537.id183102.diff
Fri, Aug 21, 10:43 PM
Unknown Object (File)
Tue, Aug 18, 8:10 AM
Unknown Object (File)
Mon, Aug 17, 10:46 PM
Unknown Object (File)
Sun, Aug 16, 5:52 AM
Unknown Object (File)
Thu, Aug 13, 5:33 AM
Unknown Object (File)
Thu, Aug 13, 12:51 AM
Unknown Object (File)
Wed, Aug 12, 9:49 PM
Unknown Object (File)
Wed, Aug 12, 5:26 PM
Subscribers

Details

Summary

Remove unused rnh_multipath and rib_algo_fixed members.
While here, convert rib_dying and rib_algo_init from uint32_t to bool.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/net/route/route_var.h
69–71

Practically a bool occupies one byte. Not sure if there is a standard about that, though. So change as is will take 2 bytes. But if you code it as bit fields, they are getting packed. With suggested change two bools will take only one byte and later you can add 6 more bools in the same manner without growing the structure.

I actually really would like us officially to promote this style instead of using pre-processor defines for flags.

pouria marked an inline comment as done.

Address @glebius comment

This revision is now accepted and ready to land.Wed, Jul 29, 11:10 PM
This revision was automatically updated to reflect the committed changes.