Paths

Table of Contentst

Differential D58506

kern_execve(): avoid storing non-VDIR into p_textdvp
ClosedPublic
Actions

Authored by kib on Tue, Jul 28, 2:35 AM.

Tags

None

Referenced Files

	F164432644: D58506.diff
	Fri, Jul 31, 10:29 PM

	F164368851: D58506.id182998.diff
	Fri, Jul 31, 6:00 AM

	F164364982: D58506.id182888.diff
	Fri, Jul 31, 5:17 AM

	Unknown Object (File)
	Fri, Jul 31, 12:38 AM

	Unknown Object (File)
	Thu, Jul 30, 11:20 PM

	Unknown Object (File)
	Thu, Jul 30, 5:00 AM

	Unknown Object (File)
	Thu, Jul 30, 3:27 AM

	Unknown Object (File)
	Wed, Jul 29, 9:00 PM

View All 13 Files

Subscribers

Details

Reviewers

markj
jah

Commits

rG930f2e4da964: kern_execve(): avoid storing non-VDIR into p_textdvp

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Tue, Jul 28, 2:35 AM

Herald added subscribers: olce, imp. · View Herald TranscriptTue, Jul 28, 2:35 AM

kib requested review of this revision.Tue, Jul 28, 2:35 AM

kib mentioned this in D58178: vfs: handle file mounts in vn_fullpath_hardlink().

Looks good to me. I have started a full stress2 test, just in case ..

09:54 /usr/src/tools/test/stress2/misc $ ./filemount_panic.sh
  PID COMM                OSREL PATH
67825 cover             1600019 /tmp/tmp.kEEk4GCRkj.renamed/cover
09:54 /usr/src/tools/test/stress2/misc $ ./filemount_panic2.sh 
mounted /bin/sleep over /tmp/filemount.VWEd7r/cover
querying kern.proc.pathname for pid 28160
pathname = /tmp/filemount.VWEd7r.renamed/cover
09:56 /usr/src/tools/test/stress2/misc $ uname -a
FreeBSD mercat1.netperf.freebsd.org 16.0-CURRENT FreeBSD 16.0-CURRENT #1 ufs-n287721-3b23d05c7781: Tue Jul 28 08:09:01 CEST 2026     pho@mercat1.netperf.freebsd.org:/var/tmp/deviant3/sys/amd64/compile/PHO amd64
09:56 /usr/src/tools/test/stress2/misc $

kib added reviewers: markj, jah.Tue, Jul 28, 8:26 AM

markj added inline comments.Tue, Jul 28, 1:56 PM

sys/kern/kern_exec.c
571	I think some comment explaining what this block does would be welcome.
589	vn_vptocnp() will drop the ref on `dvp1` before returning an error, so I think this vrele() is wrong.

Add comment.
Drop vrele().

markj added inline comments.Tue, Jul 28, 10:27 PM

sys/kern/kern_exec.c
579
580
613	Is it okay to pass a NULL newtextdvp here?

Grammar.
Guard vn_fullpath_hardlink() against NULL newtextdvp == NULL.

markj accepted this revision.Tue, Jul 28, 10:44 PM

This revision is now accepted and ready to land.Tue, Jul 28, 10:44 PM

I’m late to the party but this covers every issue I’ve run into except one dumb one that I’m not sure should live in vfs to begin with

jah accepted this revision.Wed, Jul 29, 5:21 AM

Closed by commit rG930f2e4da964: kern_execve(): avoid storing non-VDIR into p_textdvp (authored by kib). · Explain WhyThu, Jul 30, 2:57 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG930f2e4da964: kern_execve(): avoid storing non-VDIR into p_textdvp.

Revision Contents
Changeset List

Path

Size

sys/

kern/

38 lines

Diff 183089

sys/kern/kern_exec.c

Loading...