pf: fix securelevel off-by-one
ClosedPublic
Actions

Authored by kp on Tue, Jul 21, 3:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 2, 5:27 AM

	Unknown Object (File)
	Sun, Aug 2, 3:59 AM

	Unknown Object (File)
	Sat, Aug 1, 2:00 PM

	Unknown Object (File)
	Fri, Jul 31, 9:43 AM

	Unknown Object (File)
	Wed, Jul 29, 8:24 PM

	Unknown Object (File)
	Tue, Jul 28, 1:51 PM

	Unknown Object (File)
	Tue, Jul 28, 12:57 PM

	Unknown Object (File)
	Tue, Jul 28, 9:22 AM

Subscribers

shuriku_shurik.kiev.ua

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

pfsense
network

Commits

rGd13dffa150d1: pf: fix securelevel off-by-one

Summary

cmd_securelevel is the securelevel at which the call should be denied.
pf (write) calls should be denied at level 3 or up (not at 2 or up as it
was), so increment these all by one.

PR: 296838
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Tue, Jul 21, 3:08 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptTue, Jul 21, 3:08 PM

kp requested review of this revision.Tue, Jul 21, 3:08 PM

Harbormaster completed remote builds in B74980: Diff 182384.Tue, Jul 21, 3:08 PM

emaste added a subscriber: emaste.Tue, Jul 21, 3:11 PM

shuriku_shurik.kiev.ua added a subscriber: shuriku_shurik.kiev.ua.Wed, Jul 22, 8:09 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Aug 3, 4:02 PM

Closed by commit rGd13dffa150d1: pf: fix securelevel off-by-one (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGd13dffa150d1: pf: fix securelevel off-by-one.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_nl.c

94 lines

Diff 183321

View Options

pf: fix securelevel off-by-oneClosedPublicActions