netstat(1): Emit nhop flags for encoding styles with Wflag
ClosedPublic
Actions

Authored by pouria on Sun, Jul 19, 7:32 PM.

Details

Reviewers

glebius
markj
melifaro
zlei

Group Reviewers

network

Commits

rG5286cbea9118: netstat(1): Emit nhop flags for encoding styles with Wflag

Summary

Show nhop flags like invalid nexthop to debug cases like
the PR below.

PR: 296883

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pouria created this revision.Sun, Jul 19, 7:32 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Jul 19, 7:32 PM

pouria requested review of this revision.Sun, Jul 19, 7:32 PM

Harbormaster completed remote builds in B74936: Diff 182251.Sun, Jul 19, 7:32 PM

pouria added a reviewer: zlei.Thu, Jul 23, 6:12 PM

How does the output change? If changes may break someone's parser, it is worth mentioning that. Some people still have scripts that parse netstat output to automate their things.

This revision is now accepted and ready to land.Tue, Jul 28, 3:15 AM

In D58347#1342323, @glebius wrote:

How does the output change? If changes may break someone's parser, it is worth mentioning that. Some people still have scripts that parse netstat output to automate their things.

To address this concern, I only emit nhop flags output with encoding styles like json and xml, AND only if the wide flag (-W) is specified.
It won't show up in normal output even with -W.

Closed by commit rG5286cbea9118: netstat(1): Emit nhop flags for encoding styles with Wflag (authored by pouria). · Explain WhyTue, Jul 28, 8:18 AM

This revision was automatically updated to reflect the committed changes.

pouria added a commit: rG5286cbea9118: netstat(1): Emit nhop flags for encoding styles with Wflag.