Differential D58053

vfs: Fix resource leaks in kern_symlinkat()
ClosedPublic
Actions

Authored by markj on Jul 6 2026, 1:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 20, 10:33 PM

	Unknown Object (File)
	Wed, Aug 19, 1:44 PM

	Unknown Object (File)
	Sat, Aug 15, 1:25 AM

	Unknown Object (File)
	Sat, Aug 15, 1:25 AM

	Unknown Object (File)
	Sat, Aug 15, 1:25 AM

	Unknown Object (File)
	Sat, Aug 15, 1:24 AM

	Unknown Object (File)
	Mon, Aug 10, 10:04 AM

	Unknown Object (File)
	Mon, Aug 10, 9:42 AM

View All 47 Files

Subscribers

Details

Reviewers

kib
rmacklem

Commits

rGee4316c0c357: vfs: Fix resource leaks in kern_symlinkat()
rG58c73727d6e4: vfs: Fix resource leaks in kern_symlinkat()

Summary

Fixes: 2ec2ba7e232d ("vfs: Add VFS/syscall support for Solaris style extended attributes")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 6 2026, 1:38 PM

Herald added subscribers: olce, imp. · View Herald TranscriptJul 6 2026, 1:38 PM

markj requested review of this revision.Jul 6 2026, 1:38 PM

Harbormaster completed remote builds in B74543: Diff 181355.Jul 6 2026, 1:38 PM

kib accepted this revision.Jul 6 2026, 1:45 PM

kib added inline comments.

sys/kern/vfs_syscalls.c
1883	IMO it makes sense to move the VIRF_NAMEDIR check before vn_start_write(), but it would require more care for proper cleanup.

This revision is now accepted and ready to land.Jul 6 2026, 1:45 PM

rmacklem accepted this revision.Jul 6 2026, 3:19 PM

Closed by commit rG58c73727d6e4: vfs: Fix resource leaks in kern_symlinkat() (authored by markj). · Explain WhyJul 6 2026, 3:49 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG58c73727d6e4: vfs: Fix resource leaks in kern_symlinkat().

markj added a commit: rGee4316c0c357: vfs: Fix resource leaks in kern_symlinkat().Mon, Jul 27, 7:15 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

4 lines

Diff 181366

sys/kern/vfs_syscalls.c

Loading...