Page MenuHomeFreeBSD
Differential D58053

vfs: Fix resource leaks in kern_symlinkat()
ClosedPublic
Actions

Authored by markj on Mon, Jul 6, 1:38 PM.
Tags
None
Referenced Files
F161938827: D58053.diff
Wed, Jul 8, 4:38 AM
Unknown Object (File)
Tue, Jul 7, 4:23 PM
Subscribers
imp
olce

Details

Reviewers
kib
rmacklem
Commits
rG58c73727d6e4: vfs: Fix resource leaks in kern_symlinkat()
Summary

Fixes: 2ec2ba7e232d ("vfs: Add VFS/syscall support for Solaris style extended attributes")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jul 6, 1:38 PM
Herald added subscribers: olce, imp. · View Herald TranscriptMon, Jul 6, 1:38 PM
markj requested review of this revision.Mon, Jul 6, 1:38 PM
Harbormaster completed remote builds in B74543: Diff 181355.Mon, Jul 6, 1:38 PM
kib accepted this revision.Mon, Jul 6, 1:45 PM
kib added inline comments.
sys/kern/vfs_syscalls.c
1883

IMO it makes sense to move the VIRF_NAMEDIR check before vn_start_write(), but it would require more care for proper cleanup.

This revision is now accepted and ready to land.Mon, Jul 6, 1:45 PM
rmacklem accepted this revision.Mon, Jul 6, 3:19 PM
Closed by commit rG58c73727d6e4: vfs: Fix resource leaks in kern_symlinkat() (authored by markj). · Explain WhyMon, Jul 6, 3:49 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG58c73727d6e4: vfs: Fix resource leaks in kern_symlinkat().

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 181366

View Options

sys/kern/vfs_syscalls.c

Loading...