Page MenuHomeFreeBSD

socket: Tag all socket option comments consistently
AcceptedPublic

Authored by imp on Fri, Jun 12, 5:02 AM.
Tags
None
Referenced Files
F159436919: D57545.diff
Sun, Jun 14, 2:19 AM
Unknown Object (File)
Fri, Jun 12, 3:32 PM
Unknown Object (File)
Fri, Jun 12, 10:19 AM

Details

Reviewers
tuexen
pouria
peter.lei_ieee.org
Group Reviewers
transport
Summary

For all the socket options that have a fixed type, add the type of the
socket option arg to the comment. Most of them already had this, but a
few did not. The ones that don't have a tag use a variable length data
structure of some kind, and are beyond the scope of this commit.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73836
Build 70719: arc lint + arc unit

Event Timeline

imp requested review of this revision.Fri, Jun 12, 5:02 AM
tuexen added a subscriber: tuexen.

What about the IPPROTO_SCTP and IPPROTO_UDPLITE-level socket options?

This revision is now accepted and ready to land.Fri, Jun 12, 10:05 AM
pouria added inline comments.
sys/netinet6/in6.h
433

Why not fixing it?

peter.lei_ieee.org added inline comments.
sys/netinet/tcp.h
226

This could be struct tcp_fastopen: min size is an int but a full struct may be set. A get returns an int -- so, not sure if that falls into "variable length"

229

This can be struct tcp_function_set which is a fixed size struct.

230

Same here: struct tcp_function_set is fixed size.

a number of these are things I introduced, no objection