Page MenuHomeFreeBSD

socket: Tag all socket option comments consistently
ClosedPublic

Authored by imp on Fri, Jun 12, 5:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 4, 9:03 AM
Unknown Object (File)
Fri, Jul 3, 4:09 PM
Unknown Object (File)
Fri, Jul 3, 11:39 AM
Unknown Object (File)
Thu, Jul 2, 9:22 PM
Unknown Object (File)
Thu, Jul 2, 6:41 AM
Unknown Object (File)
Sun, Jun 28, 9:59 AM
Unknown Object (File)
Wed, Jun 24, 7:31 AM
Unknown Object (File)
Mon, Jun 22, 3:08 PM

Details

Summary

For all the socket options that have a fixed type, add the type of the
socket option arg to the comment. Most of them already had this, but a
few did not. The ones that don't have a tag use a variable length data
structure of some kind, and are beyond the scope of this commit.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Fri, Jun 12, 5:02 AM
tuexen added a subscriber: tuexen.

What about the IPPROTO_SCTP and IPPROTO_UDPLITE-level socket options?

This revision is now accepted and ready to land.Fri, Jun 12, 10:05 AM
pouria added inline comments.
sys/netinet6/in6.h
433

Why not fixing it?

peter.lei_ieee.org added inline comments.
sys/netinet/tcp.h
226

This could be struct tcp_fastopen: min size is an int but a full struct may be set. A get returns an int -- so, not sure if that falls into "variable length"

228–229

This can be struct tcp_function_set which is a fixed size struct.

229–230

Same here: struct tcp_function_set is fixed size.

a number of these are things I introduced, no objection

Some tweaks found while auditing the result.

This revision now requires review to proceed.Sun, Jun 14, 4:32 PM

I can take care of UDPLite and SCTP in a separate commit.

This revision is now accepted and ready to land.Sun, Jun 14, 4:44 PM
sys/netinet6/in6.h
433

Nice catch! Thanks.

I can take care of UDPLite and SCTP in a separate commit.

Excellent! Thanks!