linuxulator: Return EINVAL for invalid inotify flags
ClosedPublic
Actions

Authored by emaste on Mon, Jun 1, 6:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 13, 8:41 AM

	Unknown Object (File)
	Fri, Jun 12, 5:23 PM

	Unknown Object (File)
	Thu, Jun 11, 3:22 PM

	Unknown Object (File)
	Tue, Jun 9, 10:43 PM

	Unknown Object (File)
	Mon, Jun 8, 11:10 PM

	Unknown Object (File)
	Sun, Jun 7, 9:38 PM

	Unknown Object (File)
	Sun, Jun 7, 6:33 PM

	Unknown Object (File)
	Sun, Jun 7, 6:24 PM

View All 16 Files

Subscribers

imp

Details

Reviewers

markj

Commits

rGf77d37cffdf3: linuxulator: Return EINVAL for invalid inotify flags

Summary

We implement all of the currently-defined Linux inotify mask bits and
flags, with the same values as Linux.  Return EINVAL for unknown bits,
as Linux does.

This also moves the translation inline into linux_inotify_add_watch.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Mon, Jun 1, 6:24 PM

emaste created this revision.

markj accepted this revision.Mon, Jun 1, 6:25 PM

This revision is now accepted and ready to land.Mon, Jun 1, 6:25 PM

markj mentioned this in D57386: linux: Return an error for invalid inotify masks.Mon, Jun 1, 6:25 PM

emaste edited the summary of this revision. (Show Details)Mon, Jun 1, 6:25 PM

Closed by commit rGf77d37cffdf3: linuxulator: Return EINVAL for invalid inotify flags (authored by emaste). · Explain WhyMon, Jun 1, 6:43 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGf77d37cffdf3: linuxulator: Return EINVAL for invalid inotify flags.

Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 1, 6:43 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_file.c

18 lines

Diff 179075

View Options

sys/compat/linux/linux_file.c

linuxulator: Return EINVAL for invalid inotify flagsClosedPublicActions