Page MenuHomeFreeBSD

login.conf(5): Add missing resource limits
ClosedPublic

Authored by des on May 26 2026, 8:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 26, 6:09 AM
Unknown Object (File)
Tue, Jun 9, 9:13 AM
Unknown Object (File)
Tue, Jun 9, 9:11 AM
Unknown Object (File)
Tue, Jun 9, 7:06 AM
Unknown Object (File)
Tue, Jun 9, 7:03 AM
Unknown Object (File)
Tue, Jun 9, 2:42 AM
Unknown Object (File)
Mon, Jun 8, 7:03 PM
Unknown Object (File)
Mon, Jun 8, 7:00 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.May 26 2026, 8:23 PM

Sorting values is great. Using Ta in the header item, and only there, however, looks more confusing than anything else. What are you trying to "fix" in these headers? If it's the usage of TABs, then all the tables should be converted, not just the headers.

Trying it out for yourself is free, Olivier.

In D57258#1312183, @des wrote:

Trying it out for yourself is free, Olivier.

Mind you, I would not have written that comment if I hadn't tried first. That said, I made a mistake (displaying twice the same version), which is why I didn't see any difference. Re-doing it, there is indeed one: Sy applies only to Name in the original version.

Next time, I invite you to consider that what you chose to write and the simple "Sy applies only to Name in the original version" are about the same number of words and take the same time to write, but the first is unhelpful and mildly offensive, while the second is helpful and informative.

This revision is now accepted and ready to land.May 27 2026, 8:22 AM

tbf I'm a bit annoyed at you in particular parachuting into this review.

And for what it's worth, groff and mandoc disagree here and I'm not sure what to do about it. I'm pretty sure mandoc is in the wrong, but I haven't had much luck interacting with the mandoc maintainers in the past.

des edited the summary of this revision. (Show Details)

leave table headings alone

This revision now requires review to proceed.May 27 2026, 8:57 AM
In D57258#1312247, @des wrote:

tbf I'm a bit annoyed at you in particular parachuting into this review.

Herald rules put me as a subscriber and sometimes a reviewer in lots of places.

And for what it's worth, groff and mandoc disagree here and I'm not sure what to do about it. I'm pretty sure mandoc is in the wrong, but I haven't had much luck interacting with the mandoc maintainers in the past.

Looks the same here (weird ordering between quoting and tokenization), but I do not have time to investigate this.

This revision is now accepted and ready to land.May 27 2026, 9:09 AM
This revision was automatically updated to reflect the committed changes.