While here, reorder the table and fix table headings.
PR: 295618
MFC after: 1 week
Differential D57258
login.conf(5): Add missing resource limits Authored by des on May 26 2026, 8:23 PM. Tags None Referenced Files
Subscribers
Details While here, reorder the table and fix table headings. PR: 295618
Diff Detail
Event TimelineComment Actions Sorting values is great. Using Ta in the header item, and only there, however, looks more confusing than anything else. What are you trying to "fix" in these headers? If it's the usage of TABs, then all the tables should be converted, not just the headers. Comment Actions Mind you, I would not have written that comment if I hadn't tried first. That said, I made a mistake (displaying twice the same version), which is why I didn't see any difference. Re-doing it, there is indeed one: Sy applies only to Name in the original version. Next time, I invite you to consider that what you chose to write and the simple "Sy applies only to Name in the original version" are about the same number of words and take the same time to write, but the first is unhelpful and mildly offensive, while the second is helpful and informative. Comment Actions tbf I'm a bit annoyed at you in particular parachuting into this review. And for what it's worth, groff and mandoc disagree here and I'm not sure what to do about it. I'm pretty sure mandoc is in the wrong, but I haven't had much luck interacting with the mandoc maintainers in the past. Comment Actions Herald rules put me as a subscriber and sometimes a reviewer in lots of places.
Looks the same here (weird ordering between quoting and tokenization), but I do not have time to investigate this. |