lpd: Restore ability to specify a port number
ClosedPublic
Actions

Authored by des on Fri, May 22, 8:28 PM.

Details

Reviewers

gad
markj

Commits

rG85852fe5e4a9: lpd: Restore ability to specify a port number
rGeb5bab240e00: lpd: Restore ability to specify a port number
rGc0cae7d8da50: lpd: Restore ability to specify a port number

Summary

This has been broken since IPv6 support was added in 2000. We would
validate the port number (which had to be a port number, but can now
also be a service name) and then ignore it.

MFC after: 1 week
Fixes: 08829865f659 ("IPv6 support for lpr.")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Fri, May 22, 8:28 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, May 22, 8:28 PM

des requested review of this revision.Fri, May 22, 8:28 PM

Harbormaster completed remote builds in B73351: Diff 178429.Fri, May 22, 8:28 PM

des added a child revision: D57182: lpd: Reorder option list in manual page.Fri, May 22, 8:28 PM

markj accepted this revision.Mon, May 25, 12:37 PM

This revision is now accepted and ready to land.Mon, May 25, 12:37 PM

Closed by commit rGc0cae7d8da50: lpd: Restore ability to specify a port number (authored by des). · Explain WhyMon, May 25, 5:03 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGc0cae7d8da50: lpd: Restore ability to specify a port number.

des added a commit: rGeb5bab240e00: lpd: Restore ability to specify a port number.Thu, May 28, 8:25 AM

des added a commit: rG85852fe5e4a9: lpd: Restore ability to specify a port number.Thu, May 28, 8:27 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

lpr/

lpd/

lpd.8

19 lines

lpd.c

28 lines

Diff 178563

View Options

usr.sbin/lpr/lpd/lpd.8