lpd: Avoid buffer overflow when sending a job
ClosedPublic
Actions

Authored by des on May 22 2026, 8:28 PM.

Details

Reviewers

gad
markj

Commits

rG7c11b5f0ecdb: lpd: Avoid buffer overflow when sending a job
rG02f9207a8140: lpd: Avoid buffer overflow when sending a job
rGf2c7c5f94803: lpd: Avoid buffer overflow when sending a job

Summary

When forwarding a print job to a remote server, we could overflow the
command buffer if a control or data file had a very long name.

MFC after: 1 week
Reported by: Joshua Rogers <joshua@joshua.hu>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.May 22 2026, 8:28 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 22 2026, 8:28 PM

des requested review of this revision.May 22 2026, 8:28 PM

Harbormaster completed remote builds in B73354: Diff 178432.May 22 2026, 8:28 PM

des added a parent revision: D57183: lpd: Drop deprecated -p option.May 22 2026, 8:28 PM

des added a child revision: D57185: lpd: Fix issues reported by clang-analyzer.

markj accepted this revision.Mon, May 25, 12:47 PM

This revision is now accepted and ready to land.Mon, May 25, 12:47 PM

Closed by commit rGf2c7c5f94803: lpd: Avoid buffer overflow when sending a job (authored by des). · Explain WhyMon, May 25, 5:03 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGf2c7c5f94803: lpd: Avoid buffer overflow when sending a job.

des added a commit: rG02f9207a8140: lpd: Avoid buffer overflow when sending a job.Thu, May 28, 8:25 AM

des added a commit: rG7c11b5f0ecdb: lpd: Avoid buffer overflow when sending a job.Thu, May 28, 8:27 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

lpr/

lpd/

printjob.c

31 lines

Diff 178566

View Options

usr.sbin/lpr/lpd/printjob.c

lpd: Avoid buffer overflow when sending a jobClosedPublicActions