Page MenuHomeFreeBSD
Differential D57185

lpd: Fix issues reported by clang-analyzer
ClosedPublic
Actions

Authored by des on May 22 2026, 8:28 PM.
Tags
None
Referenced Files
F166146492: D57185.id.diff
Tue, Aug 11, 11:33 PM
F166144462: D57185.id178567.diff
Tue, Aug 11, 11:28 PM
F166142283: D57185.id178433.diff
Tue, Aug 11, 11:24 PM
F166100593: D57185.id178433.diff
Tue, Aug 11, 5:44 PM
Unknown Object (File)
Mon, Aug 10, 12:22 PM
Unknown Object (File)
Mon, Aug 10, 7:40 AM
Unknown Object (File)
Sun, Aug 9, 3:53 PM
Unknown Object (File)
Sun, Aug 9, 2:59 PM
View All 56 Files
Subscribers
imp

Details

Reviewers
gad
markj
Commits
rG980ead5949be: lpd: Fix issues reported by clang-analyzer
rGb3a76ab96216: lpd: Fix issues reported by clang-analyzer
rG0f3e14870906: lpd: Fix issues reported by clang-analyzer
Summary

Also, unlink our temporary file if we fail to chmod it.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.May 22 2026, 8:28 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 22 2026, 8:28 PM
des requested review of this revision.May 22 2026, 8:28 PM
Harbormaster completed remote builds in B73355: Diff 178433.May 22 2026, 8:28 PM
des added a parent revision: D57184: lpd: Avoid buffer overflow when sending a job.May 22 2026, 8:28 PM
des added a child revision: D57186: lpd: Style and whitespace cleanup.
markj accepted this revision.May 25 2026, 12:58 PM
markj added inline comments.
usr.sbin/lpr/lpd/printjob.c
202–203

The first sentence isn't necessarily true. I don't think it matters much though.

This revision is now accepted and ready to land.May 25 2026, 12:58 PM
des added inline comments.May 25 2026, 1:53 PM
usr.sbin/lpr/lpd/printjob.c
202–203

Barring a race condition, I think it's pretty much the only way we can get to this point with a non-zero statok, isn't it? Although perhaps we should make the fstat() unconditional and error out if it fails; just moving it into the condition for the if above should do the trick.

markj added inline comments.May 25 2026, 1:56 PM
usr.sbin/lpr/lpd/printjob.c
202–203

Yes, I was thinking of a race condition. I think checking after open() would be simpler.

des updated this revision to Diff 178550.May 25 2026, 2:35 PM

rf

This revision now requires review to proceed.May 25 2026, 2:35 PM
Harbormaster completed remote builds in B73421: Diff 178550.May 25 2026, 2:35 PM
markj accepted this revision.May 25 2026, 2:41 PM
This revision is now accepted and ready to land.May 25 2026, 2:41 PM
des marked 2 inline comments as done.May 25 2026, 5:02 PM
Closed by commit rG0f3e14870906: lpd: Fix issues reported by clang-analyzer (authored by des). · Explain WhyMay 25 2026, 5:03 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG0f3e14870906: lpd: Fix issues reported by clang-analyzer.
des added a commit: rGb3a76ab96216: lpd: Fix issues reported by clang-analyzer.May 28 2026, 8:25 AM
des added a commit: rG980ead5949be: lpd: Fix issues reported by clang-analyzer.May 28 2026, 8:28 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
lpr/
lpd/
39 lines

Diff 178567

View Options

usr.sbin/lpr/lpd/printjob.c

Loading...