Differential D57156

netlink: Fix lock leak in nl_find_nhop
ClosedPublic
Actions

Authored by emaste on May 21 2026, 10:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 21, 3:49 PM

	Unknown Object (File)
	Sun, Jun 21, 2:07 PM

	Unknown Object (File)
	Sat, Jun 20, 3:31 PM

	Unknown Object (File)
	Thu, Jun 18, 12:57 AM

	Unknown Object (File)
	Tue, Jun 16, 3:13 AM

	Unknown Object (File)
	Sun, Jun 7, 4:14 AM

	Unknown Object (File)
	Sun, Jun 7, 4:10 AM

	Unknown Object (File)
	Sat, Jun 6, 8:25 PM

View All 28 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG28833ade34e4: netlink: Fix lock leak in nl_find_nhop
rGab599e44dba3: netlink: Fix lock leak in nl_find_nhop
rGd66fec481bfd: netlink: Fix lock leak in nl_find_nhop

Summary

Fixes: 7e5bf68495cc ("netlink: add netlink support")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.May 21 2026, 10:35 PM

Herald added a reviewer: melifaro. · View Herald TranscriptMay 21 2026, 10:35 PM

Herald added subscribers: glebius, melifaro. · View Herald Transcript

emaste requested review of this revision.May 21 2026, 10:35 PM

bz accepted this revision.May 21 2026, 10:45 PM

This revision is now accepted and ready to land.May 21 2026, 10:45 PM

pouria accepted this revision.May 21 2026, 10:47 PM

pouria added a subscriber: pouria.

pouria added inline comments.

sys/netlink/route/nexthop.c
176–178	Maybe unlock it after ref_any?

emaste removed reviewers: bz, pouria.May 22 2026, 12:23 AM

emaste added inline comments.

sys/netlink/route/nexthop.c
176–178	I wondered about that, but this is consistent with the case at the end of this function. I'll make this fix first and we can consider that separately.

This revision now requires review to proceed.May 22 2026, 12:23 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2026, 12:40 AM

Closed by commit rGd66fec481bfd: netlink: Fix lock leak in nl_find_nhop (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGd66fec481bfd: netlink: Fix lock leak in nl_find_nhop.

Herald added a subscriber: imp. · View Herald TranscriptMay 22 2026, 12:40 AM

emaste added a commit: rGab599e44dba3: netlink: Fix lock leak in nl_find_nhop.Fri, Jun 5, 7:29 PM

emaste added a commit: rG28833ade34e4: netlink: Fix lock leak in nl_find_nhop.Fri, Jun 5, 7:38 PM

Revision Contents
Changeset List

Path

Size

sys/

netlink/

route/

2 lines

Diff 178359

sys/netlink/route/nexthop.c

Loading...