Page MenuHomeFreeBSD
Differential D56928

ptrace: clear TDP_USERWR after transparent attach only on attach
ClosedPublic
Actions

Authored by kib on Mon, May 11, 1:16 AM.
Tags
None
Referenced Files
F156970720: D56928.id177564.diff
Sun, May 17, 5:24 PM
F156922205: D56928.id177563.diff
Sun, May 17, 9:22 AM
F156922146: D56928.id177563.diff
Sun, May 17, 9:22 AM
F156922123: D56928.id177563.diff
Sun, May 17, 9:22 AM
F156917622: D56928.diff
Sun, May 17, 8:34 AM
F156900345: D56928.diff
Sun, May 17, 5:09 AM
F156849284: D56928.diff
Sat, May 16, 9:40 PM
Unknown Object (File)
Fri, May 15, 7:30 PM
View All 16 Files
Subscribers
emaste
imp
olce

Details

Reviewers
markj
jhb
Commits
rGcb31a266167c: ptrace: clear TDP_USERWR after transparent attach only on attach
Summary
The flag indicates that the modifying ptrace op was issued, and clearing
it after transparent attach is needed to not leak the flag to later
operations, since it is cleared on the syscall enter.

But clearing it there unconditionally is too strong.  The clearing
should be only done for attach situation.

Reported by:    Alex S <iwtcex@gmail.com>
Fixes:  99976934274de6fa19f049a0b6eac10856710f96

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Mon, May 11, 1:16 AM
Herald added subscribers: olce, imp. · View Herald TranscriptMon, May 11, 1:16 AM
kib requested review of this revision.Mon, May 11, 1:16 AM
kib updated this revision to Diff 177564.Mon, May 11, 1:37 AM
kib retitled this revision from ptrace: do no clear TDP_USERWR when fixing PT_CONTINUE after transparent attach to ptrace: clear TDP_USERWR after transparent attach only on attach.
kib edited the summary of this revision. (Show Details)

Still clear on attach.

kib edited the summary of this revision. (Show Details)Mon, May 11, 2:13 AM
markj added a comment.Tue, May 12, 3:32 PM

Is there a test case which illustrates the problem?

kib added a comment.Tue, May 12, 3:46 PM

https://github.com/shkhln/freebsd-src/commit/15be03ee2600e8ca6e89eeb5c3c409b3fbdbae87

emaste added a subscriber: emaste.Wed, May 13, 3:01 PM
markj accepted this revision.Wed, May 13, 4:13 PM
This revision is now accepted and ready to land.Wed, May 13, 4:13 PM
Closed by commit rGcb31a266167c: ptrace: clear TDP_USERWR after transparent attach only on attach (authored by kib). · Explain WhyWed, May 13, 7:40 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGcb31a266167c: ptrace: clear TDP_USERWR after transparent attach only on attach.

Revision Contents
Changeset List

PathSize
sys/
kern/
19 lines

Diff 177809

View Options

sys/kern/sys_process.c

Loading...