pci: pci_host_generic: provide cleanup methods outside of detach
ClosedPublic
Actions

Authored by kevans on May 9 2026, 2:59 AM.

Details

Reviewers

jhb
br
andrew
imp

Group Reviewers

arm64

Commits

rG31a94ec32b53: pci: pci_host_generic: provide cleanup methods outside of detach

Summary

If device_attach() fails, we're expected to actually cleanup after
ourselves because device_detach() will not be called. Factor out the
cleanup bits that don't rely on attach having actually succeeded so
that we can cleanup properly in bcm2838_pci.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.May 9 2026, 2:59 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 9 2026, 2:59 AM

kevans requested review of this revision.May 9 2026, 2:59 AM

Harbormaster completed remote builds in B72941: Diff 177476.May 9 2026, 2:59 AM

kevans added a parent revision: D56895: kern: ofw: provide ofw_bus_destroy_iinfo to teardown interrupt-map.May 9 2026, 2:59 AM

kevans added a child revision: D56897: pci: bcm2838: cleanup on attach failure to fix devmatch panic.

looks good, not sure why free vs destroy though

sys/dev/pci/pci_host_generic_fdt.c
108	why the naming difference?

kevans added inline comments.Mon, May 11, 4:33 PM

sys/dev/pci/pci_host_generic_fdt.c
108	Maybe silly, but `destroy` here to better parallel the `setup` verbiage and to match `ofw_bus_gen_destroy_devinfo`. I would've named it `free` if we had used `alloc` or nothing at all (i.e. just part of attach).