nfs_pub: move from vfs_subr.c to vfs_export.c

[rlibby]

Summary

nfs_pub is used only in vfs_export.c.

---

This is cosmetic.

Test Plan

make buildkernel

[rmacklem]

sys/kern/vfs_export.c

67

You should be able to define this as static now,
I think? And, if so, you probably want to get rid
of the "extern struct nfs_public nfs_pub;" in sys/mount.h.

[rlibby]

sys/kern/vfs_export.c

67

Yes, it will build like that. I wasn't sure if there was some other reason it was globally visible. I'll make it static in vfs_export.c if that's your preference.

Do you think that the struct nfs_public definition should also move from mount.h to vfs_export.c?

[rmacklem]

sys/kern/vfs_export.c

67

Good question. I don't have a good answer.
struct nfs_public is actually exposed to userland,
since it is not #ifdef _KERNEL'd in mount.h.

I can't think of why any third party software
would have a use for it, but??

Do whatever you think it best.
(You might want to check with kib@ if
you are going to change mount.h, since
he takes care of that.)

Even making nfs_pub static was just a
suggestion, to limit its namespace exposure.

Personally, I'd leave it in mount.h, but it's up
to you.

[rlibby]

rmacklem feedback: nfs_pub can be static in vfs_export.c