Page MenuHomeFreeBSD
Differential D56501

pf: Use MTX_DUPOK to initialize hash chain mutexes
ClosedPublic
Actions

Authored by markj on Sat, Apr 18, 12:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 29, 11:48 AM
Unknown Object (File)
Tue, Apr 28, 9:03 AM
Unknown Object (File)
Tue, Apr 28, 8:55 AM
Unknown Object (File)
Mon, Apr 27, 3:13 PM
Unknown Object (File)
Mon, Apr 27, 10:33 AM
Unknown Object (File)
Mon, Apr 27, 8:43 AM
Unknown Object (File)
Fri, Apr 24, 11:30 AM
Unknown Object (File)
Fri, Apr 24, 1:09 AM
View All 13 Files
Subscribers
farrokhi
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
kp
glebius
Commits
rGffad36e1d700: pf: Use MTX_DUPOK to initialize hash chain mutexes
Summary

pf_udp_mapping_insert() may lock more than one row at a time.

Fixes: cd5ff4e841fb ("pf: use hashalloc(9) for key, id, src-node and udp-endpoint hashes")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Sat, Apr 18, 12:12 PM
Herald added subscribers: vegeta_tuxpowered.net, melifaro, farrokhi, imp. · View Herald TranscriptSat, Apr 18, 12:12 PM
markj requested review of this revision.Sat, Apr 18, 12:12 PM
Harbormaster completed remote builds in B72322: Diff 175832.Sat, Apr 18, 12:13 PM
glebius requested changes to this revision.Sat, Apr 18, 6:58 PM

I screwed up, but not on this hash. Looking at cd5ff4e841fb I see that I lost MTX_DUPOK on UDP endpoint hash.

This revision now requires changes to proceed.Sat, Apr 18, 6:58 PM
glebius added inline comments.Sat, Apr 18, 6:58 PM
sys/netpfil/pf/pf.c
1499–1500

Should be here!

kp added a comment.Sun, Apr 19, 9:37 AM

I did see a warning about that recently but didn't investigate too much. This (with Gleb's remark) makes sense.

markj updated this revision to Diff 175904.Mon, Apr 20, 3:10 PM

Update the right hash.

Harbormaster completed remote builds in B72369: Diff 175904.Mon, Apr 20, 3:10 PM
kp added inline comments.Mon, Apr 20, 3:24 PM
sys/netpfil/pf/pf.c
1500

That wants to be 'lopts', not 'lops'.

markj updated this revision to Diff 175906.Mon, Apr 20, 3:25 PM
markj marked an inline comment as done.

Typo

Harbormaster completed remote builds in B72371: Diff 175906.Mon, Apr 20, 3:25 PM
kp accepted this revision.Mon, Apr 20, 4:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Apr 20, 4:50 PM
Closed by commit rGffad36e1d700: pf: Use MTX_DUPOK to initialize hash chain mutexes (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGffad36e1d700: pf: Use MTX_DUPOK to initialize hash chain mutexes.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
1 line

Diff 175916

View Options

sys/netpfil/pf/pf.c

Loading...