Page MenuHomeFreeBSD

Improve -hosts robustness.
ClosedPublic

Authored by trasz on Mar 16 2016, 11:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 11, 2:14 AM
Unknown Object (File)
May 2 2024, 2:57 PM
Unknown Object (File)
May 2 2024, 1:51 PM
Unknown Object (File)
May 2 2024, 1:00 PM
Unknown Object (File)
May 2 2024, 12:52 PM
Unknown Object (File)
May 2 2024, 12:52 PM
Unknown Object (File)
May 2 2024, 12:20 PM
Unknown Object (File)
Apr 24 2024, 3:27 AM
Subscribers

Details

Summary

Make the autofs(5) -hosts map more robust, primarily to make it correctly
handle NFS shares containing whitespace. This also adds the -E parameter
to showmount(8).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz retitled this revision from to Improve -hosts robustness..
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
jhibbits edited edge metadata.

Works for my use case, thanks!

This revision is now accepted and ready to land.Mar 16 2016, 2:23 PM
wblock added inline comments.
usr.bin/showmount/showmount.8
80 ↗(On Diff #14357)

As used, a colon would be appropriate instead of the dash. But this can be simpler as two sentences: (wrapping approximate)

exports list in a script-friendly format.
Client addresses and the header are not shown, and special
characters are escaped.
trasz edited edge metadata.

Improve the manual page.

This revision now requires review to proceed.Mar 17 2016, 11:06 AM

Should you handle invocation with both -E and -e explicitly?

Well, other options for showmount are effectively OR-ed... Or perhaps your suggestion is to add eg a -c options that is a modifier for -e, that makes it output script-friendly output instead of the usual?

wblock added a reviewer: wblock.

Works for me!

Macro goatforit: close enough!

This revision is now accepted and ready to land.Mar 17 2016, 9:45 PM
In D5649#120966, @trasz wrote:

Well, other options for showmount are effectively OR-ed... Or perhaps your suggestion is to add eg a -c options that is a modifier for -e, that makes it output script-friendly output instead of the usual?

I think other options for showmount don't conflict with each other in the same way; passing both -e and -E here seems like it would would produce nonsensical output. I think it should either allow only one of -e and -E or the script mode should be a separate option like the -c you suggest.

trasz edited edge metadata.

Make the -E option conflict with all the others.

This revision now requires review to proceed.Mar 22 2016, 4:54 PM
jhibbits edited edge metadata.
This revision is now accepted and ready to land.Mar 22 2016, 4:57 PM
emaste edited edge metadata.
This revision was automatically updated to reflect the committed changes.