Page MenuHomeFreeBSD
Differential D56253

ip6_mroute: VNETify counters
AcceptedPublic
Actions

Authored by markj on Sat, Apr 4, 11:22 AM.

Details

Reviewers
zlei
pouria
Group Reviewers
network
Summary

Commit a223d6c489c7 made most of the ip6_mroute state per-VNET, but
failed to do this for a couple of counter structures. Make them
per-VNET too.

Reported by: zlei
Fixes: a223d6c489c7 ("ip6_mroute: Start putting global variables into a structure")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71962
Build 68845: arc lint + arc unit

Event Timeline

markj created this revision.Sat, Apr 4, 11:22 AM
Herald added a reviewer: pouria. · View Herald TranscriptSat, Apr 4, 11:22 AM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript
markj requested review of this revision.Sat, Apr 4, 11:22 AM
Harbormaster completed remote builds in B71962: Diff 174917.Sat, Apr 4, 11:22 AM
pouria accepted this revision as: pouria.Sat, Apr 4, 11:27 AM

LGTM

This revision is now accepted and ready to land.Sat, Apr 4, 11:27 AM
markj mentioned this in D56205: netstat: Add -F support for -g.Sat, Apr 4, 11:28 AM
zlei accepted this revision as: zlei.Sat, Apr 4, 3:09 PM

Looks good to me.

sys/netinet6/ip6_mroute.c
162

Not related to this revision.

I'd expect the sysctls for statistics are all read-only. Any usage to update / reset those statistics by end user ?

zlei added inline comments.Sat, Apr 4, 3:37 PM
sys/netinet6/ip6_mroute.c
162

Oh, I found the related commit d96ea877a78d. Those sysctls are made writable by intention. Quote from the commit message,

o Convert IPv6 read-only stats sysctls to the read-write ones.
o Teach netstat(1) -z to reset these stats sysctls.

Ralated PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=153206 .

markj added inline comments.Mon, Apr 6, 2:53 AM
sys/netinet6/ip6_mroute.c
162

Right. See the implementation of the SYSCTL_VNET_PCPUSTAT macro, any write to the sysctl just sets the counters to 0.

Here we should at some point go further and use per-CPU stats as well, but that should be done as a larger performance evaluation of this code.

Revision Contents
Changeset List

PathSize
sys/
netinet6/
18 lines

Diff 174917

View Options

sys/netinet6/ip6_mroute.c

Loading...