Page MenuHomeFreeBSD
Differential D56145

tests/pf/nat: endpoint_independent: wait for tcpdump to start
Needs RevisionPublic
Actions

Authored by siva on Sun, Mar 29, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 4, 8:18 PM
Unknown Object (File)
Fri, Apr 3, 10:56 PM
Unknown Object (File)
Fri, Apr 3, 10:26 PM
Unknown Object (File)
Mon, Mar 30, 12:39 PM
Subscribers
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
kp
emaste
thj
glebius
Summary

This matches pflog.sh tests and fixes flaky tests found in CI[0].

[0] https://ci.freebsd.org/job/FreeBSD-main-amd64-test/28126/testReport/junit/sys.netpfil.pf/nat/endpoint_independent_exhaust/

PR: 289628

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71792
Build 68675: arc lint + arc unit

Event Timeline

siva created this revision.Sun, Mar 29, 2:45 PM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSun, Mar 29, 2:45 PM
siva requested review of this revision.Sun, Mar 29, 2:45 PM
Harbormaster completed remote builds in B71792: Diff 174477.Sun, Mar 29, 2:45 PM
siva added a reviewer: thj.Thu, Apr 2, 2:04 PM
glebius requested changes to this revision.Thu, Apr 2, 4:30 PM

I already went through this in other test cases. A sleep for a second makes test slower to execute but still doesn't give a 100% protection against flakyness. When tests are executed in parallel on a slow machine you may still have a failure sometimes. Here is the solution I came to so far, poll until tcpdump(1)s are all blocked on "bpf" wait channel. See 38edf96b1787ce3d8c00e4466348dab891c7a9ea.

This revision now requires changes to proceed.Thu, Apr 2, 4:30 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
netpfil/
pf/
2 lines

Diff 174477

View Options

tests/sys/netpfil/pf/nat.sh

Loading...