Page MenuHomeFreeBSD

tests/pf/nat: endpoint_independent: wait for tcpdump to start
ClosedPublic

Authored by siva on Mar 29 2026, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 12, 10:24 AM
Unknown Object (File)
Sun, Oct 11, 2:19 AM
Unknown Object (File)
Sat, Oct 10, 9:51 PM
Unknown Object (File)
Fri, Oct 9, 4:01 PM
Unknown Object (File)
Fri, Oct 9, 4:01 PM
Unknown Object (File)
Fri, Oct 9, 3:20 PM
Unknown Object (File)
Thu, Oct 8, 9:54 PM
Unknown Object (File)
Thu, Oct 8, 12:08 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

siva requested review of this revision.Mar 29 2026, 2:45 PM
glebius requested changes to this revision.Apr 2 2026, 4:30 PM

I already went through this in other test cases. A sleep for a second makes test slower to execute but still doesn't give a 100% protection against flakyness. When tests are executed in parallel on a slow machine you may still have a failure sometimes. Here is the solution I came to so far, poll until tcpdump(1)s are all blocked on "bpf" wait channel. See 38edf96b1787ce3d8c00e4466348dab891c7a9ea.

This revision now requires changes to proceed.Apr 2 2026, 4:30 PM

Thanks for the feedback, this approach looks good. I've tested it with 2000+ runs,
the flakiness is gone.

This revision is now accepted and ready to land.Apr 10 2026, 3:37 PM