diff3: prefer posix_spawn over pdfork/execlp
ClosedPublic
Actions

Authored by bapt on Mar 25 2026, 10:09 AM.

Tags

None

Referenced Files

	F155038240: D56075.id174278.diff
	Thu, Apr 30, 9:09 PM

	F155037920: D56075.id174278.diff
	Thu, Apr 30, 9:05 PM

	Unknown Object (File)
	Wed, Apr 29, 5:06 AM

	Unknown Object (File)
	Tue, Apr 28, 7:34 PM

	Unknown Object (File)
	Tue, Apr 28, 7:25 PM

	Unknown Object (File)
	Tue, Apr 28, 1:53 PM

	Unknown Object (File)
	Tue, Apr 28, 3:48 AM

	Unknown Object (File)
	Mon, Apr 27, 5:20 PM

View All 27 Files

Subscribers

imp

Details

Reviewers

kib

Commits

rG210f4d82757b: diff3: prefer posix_spawn over pdfork/execlp
rG5f7f0efe8e13: diff3: prefer posix_spawn over pdfork/execlp

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Mar 25 2026, 10:09 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 25 2026, 10:09 AM

bapt requested review of this revision.Mar 25 2026, 10:09 AM

Harbormaster completed remote builds in B71706: Diff 174278.Mar 25 2026, 10:09 AM

bapt added a reviewer: kib.Mar 25 2026, 10:49 AM

Unrelated note: it seems that pipe fds leak to both pd13 and pd23 processes. This is perhaps not too important but just not accurate. And since we care about 'security' by entering cap mode, ability of the children to affect input of siblings or parent might be considered undesirable.