Page MenuHomeFreeBSD

in6_mcast: Acquire ref to ifp and exit epoch earlier in sysctl
AcceptedPublic

Authored by pouria on Mon, Mar 23, 6:49 PM.

Details

Reviewers
zlei
bz
glebius
bms
Group Reviewers
network
Summary

Acquire reference to interface and
exit net_epoch earlier in ifmcstat sysctl.

IMPORTANT:

This patch will not completely fix the underlying problem, and
I don't consider it an appropriate long-term solution.

The real fix is to migrate to netlink instead of using sysctl and to avoid
wiring user memory while holding various locks (including vslock). That will
take time.
I am proposing this as a short-term remedy in response to zlei's email to reduce
amount of witness warning.

Personally, I prefer to wait until netlink migration is complete.

Test Plan

Run netinet6 tests

kyua test -k /usr/tests/Kyuafile sys/netinet6

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71675
Build 68558: arc lint + arc unit

Event Timeline

No objection to using netlink instead of sysctl for retrieving group state in principle.

This revision is now accepted and ready to land.Mon, Mar 23, 9:19 PM