Page MenuHomeFreeBSD
Differential D55765

dtrace: Improve dmesg kernel message prefix
AcceptedPublic
Actions

Authored by ziaee on Mon, Mar 9, 2:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 5, 1:17 PM
Unknown Object (File)
Sun, Mar 29, 11:55 PM
Unknown Object (File)
Fri, Mar 20, 12:49 PM
Unknown Object (File)
Fri, Mar 20, 7:55 AM
Unknown Object (File)
Wed, Mar 18, 12:05 PM
Unknown Object (File)
Tue, Mar 17, 9:12 PM
Unknown Object (File)
Tue, Mar 17, 4:30 AM
Unknown Object (File)
Wed, Mar 11, 8:35 AM
View All 11 Files
Subscribers
0mp
emaste
imp
markj

Details

Reviewers
mav
0mp
Group Reviewers
DTrace
Summary

I chose lowercase for consistency with other kernel messages.
We're making a similar change in OpenZFS.

Reported by: mav
MFC after: 1 month
OpenZFS change: https://github.com/openzfs/zfs/pull/18290

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71280
Build 68163: arc lint + arc unit

Event Timeline

ziaee created this revision.Mon, Mar 9, 2:44 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Mar 9, 2:44 PM
Harbormaster completed remote builds in B71280: Diff 173424.Mon, Mar 9, 2:44 PM
ziaee requested review of this revision.Mon, Mar 9, 2:44 PM
0mp accepted this revision as: 0mp.Mon, Mar 9, 2:55 PM
0mp added a subscriber: 0mp.

Good idea.

Shouldn't that be DTrace instead of dtrace?

This revision is now accepted and ready to land.Mon, Mar 9, 2:55 PM
ziaee added a comment.Mon, Mar 9, 3:01 PM

Good idea.

Thank you!

Shouldn't that be DTrace instead of dtrace?

I don't know. I only know drivers are lowercase, and it looks nice when they're similar, so for the corresponding change in OpenZFS we made it lowercase.

ziaee added a comment.Mon, Mar 9, 5:35 PM

The corresponding change has been merged into OpenZFS.

emaste added a subscriber: emaste.Mon, Mar 9, 7:43 PM

Is assfail actually used? I see a dtrace_assfail in dtrace code. (Didn't check the others.)

markj added a subscriber: markj.Tue, Mar 10, 1:49 AM

I think this is fine. It's a bit of layering violation since opensolaris is supposed to be able to serve multiple consumers (dtrace and ZFS in the past, just dtrace now). I'm in favour of converting assertion and print function calls in dtrace to just using FreeBSD interfaces directly.

Revision Contents
Changeset List

PathSize
sys/
cddl/
compat/
opensolaris/
kern/
14 lines

Diff 173424

View Options

sys/cddl/compat/opensolaris/kern/opensolaris_cmn_err.c

Loading...