virtio: add loader tunables to sysctl
ClosedPublic
Actions

Authored by timo.voelker_fh-muenster.de on Feb 26 2026, 3:15 PM.

Details

Reviewers

bryanv
grehan
tuexen
imp

Group Reviewers

manpages

Commits

rGc70755bc0d8f: virtio: add loader tunables to sysctl

Summary

virtio_pci uses two loader tunables that should be more visible. This patch adds these loader tunables to sysctl and describes them in the virtio(4) man page.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

timo.voelker_fh-muenster.de created this revision.Feb 26 2026, 3:15 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFeb 26 2026, 3:15 PM

timo.voelker_fh-muenster.de requested review of this revision.Feb 26 2026, 3:15 PM

imp accepted this revision.Feb 26 2026, 5:15 PM

This revision is now accepted and ready to land.Feb 26 2026, 5:15 PM

tuexen added inline comments.Feb 26 2026, 7:26 PM

share/man/man4/virtio.4
25	Please bump the date.
108	Isn't the default value 0 right now?
sys/dev/virtio/pci/virtio_pci_modern.c
198	Can this be shorter? Maybe: If zero or non-zero, transitional VirtIO devices negotiate legacy or modern mode.

ziaee added inline comments.Feb 26 2026, 8:01 PM

share/man/man4/virtio.4
59–60	At the bottom of mdoc(7) it links to the extended style guide maintained by our manpage compiler which states you use Sy for things which have no manual in this operating system, for visual consistency with Nm.
100	per style.mdoc(5)
105–108

Addressed comments from @tuexen and @ziaee.

This revision now requires review to proceed.Feb 28 2026, 8:04 AM

timo.voelker_fh-muenster.de marked 6 inline comments as done.Feb 28 2026, 8:11 AM

timo.voelker_fh-muenster.de added inline comments.

share/man/man4/virtio.4
59–60	I looked for an alternative to Xr. Sy is perfect, thanks!
108	Isn't the default value 0 right now? Good catch!
sys/dev/virtio/pci/virtio_pci_modern.c
198	Sure. How about this one?