Page MenuHomeFreeBSD
Differential D55382

netinet6: Document IPv4-mapped extension to IPV6_JOIN_GROUP et al.
AcceptedPublic
Actions

Authored by bms on Thu, Feb 19, 7:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 14, 11:59 PM
Unknown Object (File)
Mon, Mar 9, 8:25 PM
Unknown Object (File)
Mon, Mar 9, 4:46 PM
Unknown Object (File)
Sun, Mar 8, 8:53 PM
Unknown Object (File)
Wed, Mar 4, 11:16 PM
Unknown Object (File)
Wed, Mar 4, 5:07 PM
Unknown Object (File)
Wed, Mar 4, 12:12 AM
Unknown Object (File)
Mon, Mar 2, 11:16 AM
View All 16 Files
Subscribers
ziaee

Details

Reviewers
glebius
imp
kp
pouria
ziaee
Group Reviewers
network

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70794
Build 67677: arc lint + arc unit

Event Timeline

bms created this revision.Thu, Feb 19, 7:29 PM
Herald added a subscriber: ziaee. · View Herald TranscriptThu, Feb 19, 7:29 PM
bms requested review of this revision.Thu, Feb 19, 7:29 PM
Harbormaster completed remote builds in B70794: Diff 172274.Thu, Feb 19, 7:29 PM
bms added a reviewer: network.Thu, Feb 19, 7:31 PM
pouria accepted this revision as: pouria.Thu, Feb 19, 8:49 PM
pouria added inline comments.
share/man/man4/ip6.4
507

I'm not sure if we should include the OS version here, since we don't want to MFC this revision to older versions.

517

IMHO, there is no need to mention OpenJDK here and state that it is widely adopted.

This revision is now accepted and ready to land.Thu, Feb 19, 8:49 PM
pouria added a reviewer: ziaee.Thu, Feb 19, 8:49 PM
bms added a comment.Thu, Feb 19, 9:07 PM

There seems to be significant demand from the user base for this "feature", probably because the OpenJDK is the main consumer of it, and it is doing something in-kernel that the OpenJDK socket shims handled themselves historically anyway.

glebius added a comment.Thu, Feb 26, 3:35 AM

I added some suggestion, but they are IMHOs. I'd suggest to wait for approval from a doc committer. @ziaee maybe you?

share/man/man4/ip6.4
199–224

IMHO, the content suggested for addition actually belongs to this part of the manual page.

507

Agreed. AFAIK, a content chapter of a manual page shall not talk about FreeBSD versions. It should just list factual information that matches the branch. The information about which version introduced what can be optionally added to the HISTORY chapter at the end of the manual page.

517

Yep, mentioning a particular out of the project program is not desired.

Also I'd suggest to remove work "undocumented", cause now it is documented.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
15 lines

Diff 172274

View Options

share/man/man4/ip6.4

Loading...