Page MenuHomeFreeBSD

dpaa2: ni: add more stats and link information
AcceptedPublic

Authored by bz on Tue, Feb 17, 3:23 AM.
Tags
None
Referenced Files
F145933568: D55321.diff
Thu, Feb 26, 7:34 AM
Unknown Object (File)
Wed, Feb 25, 6:30 AM
Unknown Object (File)
Mon, Feb 23, 6:13 AM
Unknown Object (File)
Fri, Feb 20, 5:19 PM
Unknown Object (File)
Wed, Feb 18, 2:44 AM
Unknown Object (File)
Tue, Feb 17, 12:03 PM
Unknown Object (File)
Tue, Feb 17, 11:34 AM
Unknown Object (File)
Tue, Feb 17, 5:14 AM
Subscribers

Details

Summary

In addition to the locally generated statistics counters, dpaa2 ni
provides a larger set of counters than we currently export via
sysctl. Add (most of) the missing counters and descriptions.
Around Page 3/4 there are some things left to do if we want.
Also the manual was not clear on the descriptions of 3/0 and 3/1.

The second half of the change adds another sysctl note which exports
the link-state, speed, and capabilities set as a text-blob. This is
especially interesting in case the "ni" stops passing packets.
From what I have found in that case the (internal) link state of the
ni goes DOWN but we do not see an interrupt for a link-state change.

Being able to diagnose the state helps to (manually) fix it for now
by changing the media status to 10BaseT or none and then back to auto.
That usually brings the internal link state back UP.

MFC after: 3 days
PR: 279352

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70721
Build 67604: arc lint + arc unit

Event Timeline

bz requested review of this revision.Tue, Feb 17, 3:23 AM
dsl added inline comments.
sys/dev/dpaa2/dpaa2_ni.c
3592

I don't understand those option bits and sbuf(9) doesn't help me much, but it's likely my problem. Everything else LGTM.

This revision is now accepted and ready to land.Sat, Feb 21, 3:05 PM