Page MenuHomeFreeBSD
Differential D55259

ngctl: Fix buffer overflow in config command
ClosedPublic
Actions

Authored by des on Feb 12 2026, 12:36 AM.
Tags
None
Referenced Files
F159644197: D55259.id.diff
Tue, Jun 16, 2:11 PM
F159593191: D55259.id171805.diff
Tue, Jun 16, 1:15 AM
Unknown Object (File)
Sat, Jun 13, 1:09 PM
Unknown Object (File)
Sat, Jun 13, 5:53 AM
Unknown Object (File)
Tue, Jun 9, 3:08 AM
Unknown Object (File)
Sun, May 24, 12:42 PM
Unknown Object (File)
Sat, May 23, 12:49 AM
Unknown Object (File)
Wed, May 20, 12:00 AM
View All 43 Files
Subscribers
donner
imp
zlei

Details

Reviewers
kevans
markj
zlei
Commits
rGf16fc39527ee: ngctl: Fix buffer overflow in config command
rG2b11bbd790ac: ngctl: Fix buffer overflow in config command
rGe5bf728058da: ngctl: Fix buffer overflow in config command
rG669347f67a07: ngctl: Fix buffer overflow in config command
rG59906a163e47: ngctl: Fix buffer overflow in config command
Summary

Keep track of our buffer length when assembling the argument list.

PR: 293075
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Feb 12 2026, 12:36 AM
Herald added subscribers: donner, imp. · View Herald TranscriptFeb 12 2026, 12:36 AM
des requested review of this revision.Feb 12 2026, 12:36 AM
Harbormaster completed remote builds in B70634: Diff 171805.Feb 12 2026, 12:36 AM
des added a parent revision: D55258: ngctl: Check hook name length.Feb 12 2026, 12:36 AM
markj accepted this revision.Feb 12 2026, 2:45 PM
This revision is now accepted and ready to land.Feb 12 2026, 2:45 PM
markj mentioned this in D55254: ngctl: Check for overflow when assembling a config command.Feb 12 2026, 2:46 PM
zlei accepted this revision.Feb 12 2026, 3:24 PM
zlei added a subscriber: zlei.

Solid fix !

Closed by commit rG59906a163e47: ngctl: Fix buffer overflow in config command (authored by des). · Explain WhyFeb 13 2026, 4:02 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG59906a163e47: ngctl: Fix buffer overflow in config command.
des added a commit: rG669347f67a07: ngctl: Fix buffer overflow in config command.Feb 17 2026, 11:58 PM
des added a commit: rGe5bf728058da: ngctl: Fix buffer overflow in config command.Feb 18 2026, 12:09 AM
des added a commit: rG2b11bbd790ac: ngctl: Fix buffer overflow in config command.Feb 18 2026, 12:15 AM
cperciva added a commit: rGf16fc39527ee: ngctl: Fix buffer overflow in config command.Feb 18 2026, 1:54 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
ngctl/
22 lines

Diff 171869

View Options

usr.sbin/ngctl/config.c

Loading...