ngctl: Fix buffer overflow in config command
ClosedPublic
Actions

Authored by des on Thu, Feb 12, 12:36 AM.

Tags

None

Referenced Files

	F145224767: D55259.diff
	Tue, Feb 17, 7:15 AM

	F145192513: D55259.id.diff
	Mon, Feb 16, 11:10 PM

	Unknown Object (File)
	Mon, Feb 16, 1:34 AM

	Unknown Object (File)
	Sun, Feb 15, 11:47 PM

	Unknown Object (File)
	Sun, Feb 15, 12:09 AM

	Unknown Object (File)
	Sat, Feb 14, 1:36 PM

	Unknown Object (File)
	Thu, Feb 12, 2:48 PM

	Unknown Object (File)
	Thu, Feb 12, 12:51 PM

Subscribers

Details

Reviewers

kevans
markj
zlei

Commits

rG59906a163e47: ngctl: Fix buffer overflow in config command

Summary

Keep track of our buffer length when assembling the argument list.

PR: 293075
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Thu, Feb 12, 12:36 AM

Herald added subscribers: donner, imp. · View Herald TranscriptThu, Feb 12, 12:36 AM

des requested review of this revision.Thu, Feb 12, 12:36 AM

Harbormaster completed remote builds in B70634: Diff 171805.Thu, Feb 12, 12:36 AM

des added a parent revision: D55258: ngctl: Check hook name length.Thu, Feb 12, 12:36 AM

markj accepted this revision.Thu, Feb 12, 2:45 PM

This revision is now accepted and ready to land.Thu, Feb 12, 2:45 PM

markj mentioned this in D55254: ngctl: Check for overflow when assembling a config command.Thu, Feb 12, 2:46 PM

Solid fix !

Closed by commit rG59906a163e47: ngctl: Fix buffer overflow in config command (authored by des). · Explain WhyFri, Feb 13, 4:02 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG59906a163e47: ngctl: Fix buffer overflow in config command.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ngctl/

config.c

22 lines

Diff 171869

View Options

ngctl: Fix buffer overflow in config commandClosedPublicActions